All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <w.sang@pengutronix.de>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org,
	microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH 0/4] Merge OF dynamic patches
Date: Wed, 18 Nov 2009 11:41:47 +0100	[thread overview]
Message-ID: <20091118104147.GD5166@pengutronix.de> (raw)
In-Reply-To: <4B030FC2.9070401@austin.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

On Tue, Nov 17, 2009 at 03:04:02PM -0600, Nathan Fontenot wrote:
> This set of patches merges the common dynamic device tree
> updating routines of_attach_node() and of_detach_node() to
> drivers/of/of_dynamic.c.
>
> Built and tested on powerpc, I have no access to build/test
> this on microblaze.

They look good, but I can't test them as they don't apply to test-devicetree.
On which commit are they based?

It would be nice if you could also add a diffstat to every patch, this makes
reviewing 'move-around'-patches a bit easier.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <w.sang@pengutronix.de>
To: Nathan Fontenot <nfont@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org, devicetree-discuss@lists.ozlabs.org,
	microblaze-uclinux@itee.uq.edu.au
Subject: Re: [PATCH 0/4] Merge OF dynamic patches
Date: Wed, 18 Nov 2009 11:41:47 +0100	[thread overview]
Message-ID: <20091118104147.GD5166@pengutronix.de> (raw)
In-Reply-To: <4B030FC2.9070401@austin.ibm.com>


[-- Attachment #1.1: Type: text/plain, Size: 732 bytes --]

On Tue, Nov 17, 2009 at 03:04:02PM -0600, Nathan Fontenot wrote:
> This set of patches merges the common dynamic device tree
> updating routines of_attach_node() and of_detach_node() to
> drivers/of/of_dynamic.c.
>
> Built and tested on powerpc, I have no access to build/test
> this on microblaze.

They look good, but I can't test them as they don't apply to test-devicetree.
On which commit are they based?

It would be nice if you could also add a diffstat to every patch, this makes
reviewing 'move-around'-patches a bit easier.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 150 bytes --]

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

  parent reply	other threads:[~2009-11-18 10:41 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-17 21:04 [PATCH 0/4] Merge OF dynamic patches Nathan Fontenot
2009-11-17 21:04 ` Nathan Fontenot
2009-11-18  2:53 ` [PATCH 1/4] Merge of_attach_node Nathan Fontenot
2009-11-18  2:53   ` Nathan Fontenot
     [not found]   ` <4B0361A9.20209-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
2009-11-18 21:44     ` Nathan Fontenot
2009-11-18  2:55 ` [PATCH 2/4] Merge of_detach_node Nathan Fontenot
     [not found]   ` <4B03620C.2060105-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
2009-11-18 21:45     ` Nathan Fontenot
2009-11-18  2:56 ` [PATCH 3/4] Makefile and Kconfig updates for of_dynamci Nathan Fontenot
     [not found]   ` <4B036256.9060809-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
2009-11-18 21:46     ` Nathan Fontenot
2009-11-18  2:57 ` [PATCH 4/4] Move of_node[attach,detach] declarations to linux/of.h Nathan Fontenot
     [not found]   ` <4B03629A.9050503-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
2009-11-18 21:48     ` [PATCH 4/4] Move of_node[attach, detach] " Nathan Fontenot
     [not found]       ` <4B046B92.3060108-V7BBcbaFuwjMbYB6QlFGEg@public.gmane.org>
2009-11-19  5:35         ` Andres Salomon
     [not found]           ` <20091119003517.677a5b02-d8A+jLeiQi/1Xlz9cAVuGNHuzzzSOjJt@public.gmane.org>
2009-11-19 20:32             ` Nathan Fontenot
2009-11-18 10:41 ` Wolfram Sang [this message]
2009-11-18 10:41   ` [PATCH 0/4] Merge OF dynamic patches Wolfram Sang
2009-11-18 20:16   ` Nathan Fontenot
2009-11-18 20:16     ` Nathan Fontenot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091118104147.GD5166@pengutronix.de \
    --to=w.sang@pengutronix.de \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=microblaze-uclinux@itee.uq.edu.au \
    --cc=nfont@austin.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.