Patches for Samsung SoC PCM Controller driver

Patches for Samsung SoC PCM Controller driver

[Jassi Brar]

Hello,

(I re-submit patches after making changes suggested yesterday by Ben Dooks.)

Samsung SoCs S3C2450, S3C64XX and later versions have got PCM controllers
which drive what the ALSA stack terms DSP_A/DSP_B formats.

Since the S3C ALSA platform driver was named s3c24xx-pcm, which cause
direct namespace clash with the new PCM controller drivers, it has been
renamed along with some of its local symbols.

First two of the following series of patches does that and later ones
make ground for and add the PCM controller driver.

regards.

Re: Patches for Samsung SoC PCM Controller driver

[Mark Brown]

On Tue, Nov 17, 2009 at 04:53:17PM +0900, Jassi Brar wrote:

> (I re-submit patches after making changes suggested yesterday by Ben Dooks.)

This all looks OK apart from the comments I posted (no need to repost
for those, though).  It'd be good to get Ben's ack, though, since bits
of this touch arch/arm.

Re: Patches for Samsung SoC PCM Controller driver

[jassi brar]

On Tue, Nov 17, 2009 at 8:59 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Nov 17, 2009 at 04:53:17PM +0900, Jassi Brar wrote:
>
>> (I re-submit patches after making changes suggested yesterday by Ben Dooks.)
>
> This all looks OK apart from the comments I posted (no need to repost
> for those, though).  It'd be good to get Ben's ack, though, since bits
> of this touch arch/arm.
In previous to this set, I implemented whatever you suggested.
This submission added, upon the last one, only what Ben wanted.
If i forgot something from your comments please lemme know.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: Patches for Samsung SoC PCM Controller driver

[Mark Brown]

On Tue, Nov 17, 2009 at 04:53:17PM +0900, Jassi Brar wrote:

> Samsung SoCs S3C2450, S3C64XX and later versions have got PCM controllers
> which drive what the ALSA stack terms DSP_A/DSP_B formats.

Applied all except patch 4, thanks.

Please do try to follow the subject line conventions for the subsystem
you're submitting to when sending patches - it makes them much easier to
apply.

Re: Patches for Samsung SoC PCM Controller driver

[jassi brar]

On Wed, Nov 18, 2009 at 10:06 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Tue, Nov 17, 2009 at 04:53:17PM +0900, Jassi Brar wrote:
>
>> Samsung SoCs S3C2450, S3C64XX and later versions have got PCM controllers
>> which drive what the ALSA stack terms DSP_A/DSP_B formats.
>
> Applied all except patch 4, thanks.
>
> Please do try to follow the subject line conventions for the subsystem
> you're submitting to when sending patches - it makes them much easier to
> apply.

well, the patches that were neither 64xx nor PCM specific, we marked
"S3C AUDIO", those specific were marked "S3C64XX PCM" and the driver
was marked "S3C PCM" since that is supposed to run all PCM controllers
of S3C series.
Thanks.

Re: Patches for Samsung SoC PCM Controller driver

[Mark Brown]

On Thu, Nov 19, 2009 at 01:25:47PM +0900, jassi brar wrote:

> well, the patches that were neither 64xx nor PCM specific, we marked
> "S3C AUDIO", those specific were marked "S3C64XX PCM" and the driver
> was marked "S3C PCM" since that is supposed to run all PCM controllers
> of S3C series.

The bit that's missing is that for the subsystem - "ASoC: " for the
ASoC bits.

Patches for Samsung SoC PCM Controller driver

[Jassi Brar]

Hello,

Samsung SoCs S3C2450, S3C64XX and later versions have got PCM controllers
which drive what the ALSA stack terms DSP_A/DSP_B formats.

Since the S3C ALSA platform driver was named s3c24xx-pcm, which cause
direct namespace clash with the new PCM controller drivers, it has been
renamed along with some of its local symbols.

First two of the following series of patches does that and later ones
make ground for and add the PCM controller driver.

regards.