[PATCH] selinux: Fix warnings

[PATCH] selinux: Fix warnings

[Alan Cox]

scripts/selinux/genheaders/genheaders.c:20: warning: no previous prototype  
for ‘usage’
scripts/selinux/genheaders/genheaders.c:26: warning: no previous prototype
for ‘stoupperx’

Signed-off-by: Alan Cox <alan@linux.intel.com>
---

 scripts/selinux/genheaders/genheaders.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
index 3b16145..771b86f 100644
--- a/scripts/selinux/genheaders/genheaders.c
+++ b/scripts/selinux/genheaders/genheaders.c
@@ -17,13 +17,13 @@ struct security_class_mapping {
 
 const char *progname;
 
-void usage(void)
+static void usage(void)
 {
 	printf("usage: %s flask.h av_permissions.h\n", progname);
 	exit(1);
 }
 
-char *stoupperx(const char *s)
+static char *stoupperx(const char *s)
 {
 	char *s2 = strdup(s);
 	char *p;

Re: [PATCH] selinux: Fix warnings

[Américo Wang]

On Wed, Nov 18, 2009 at 02:39:51PM +0000, Alan Cox wrote:
>scripts/selinux/genheaders/genheaders.c:20: warning: no previous prototype  
>for ‘usage’
>scripts/selinux/genheaders/genheaders.c:26: warning: no previous prototype
>for ‘stoupperx’
>
>Signed-off-by: Alan Cox <alan@linux.intel.com>

Acked-by: WANG Cong <xiyou.wangcong@gmail.com>

>---
>
> scripts/selinux/genheaders/genheaders.c |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>
>diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
>index 3b16145..771b86f 100644
>--- a/scripts/selinux/genheaders/genheaders.c
>+++ b/scripts/selinux/genheaders/genheaders.c
>@@ -17,13 +17,13 @@ struct security_class_mapping {
> 
> const char *progname;
> 
>-void usage(void)
>+static void usage(void)
> {
> 	printf("usage: %s flask.h av_permissions.h\n", progname);
> 	exit(1);
> }
> 
>-char *stoupperx(const char *s)
>+static char *stoupperx(const char *s)
> {
> 	char *s2 = strdup(s);
> 	char *p;
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 

Re: [PATCH] selinux: Fix warnings

[James Morris]

On Thu, 19 Nov 2009, Am?rico Wang wrote:

> On Wed, Nov 18, 2009 at 02:39:51PM +0000, Alan Cox wrote:
> >scripts/selinux/genheaders/genheaders.c:20: warning: no previous prototype  
> >for ?usage?
> >scripts/selinux/genheaders/genheaders.c:26: warning: no previous prototype
> >for ?stoupperx?
> >
> >Signed-off-by: Alan Cox <alan@linux.intel.com>
> 
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
> 

Thanks.


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

> >---
> >
> > scripts/selinux/genheaders/genheaders.c |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >
> >diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
> >index 3b16145..771b86f 100644
> >--- a/scripts/selinux/genheaders/genheaders.c
> >+++ b/scripts/selinux/genheaders/genheaders.c
> >@@ -17,13 +17,13 @@ struct security_class_mapping {
> > 
> > const char *progname;
> > 
> >-void usage(void)
> >+static void usage(void)
> > {
> > 	printf("usage: %s flask.h av_permissions.h\n", progname);
> > 	exit(1);
> > }
> > 
> >-char *stoupperx(const char *s)
> >+static char *stoupperx(const char *s)
> > {
> > 	char *s2 = strdup(s);
> > 	char *p;
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Live like a child, think like the god.
>  
> 

-- 
James Morris
<jmorris@namei.org>

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] selinux: Fix warnings

[James Morris]

On Thu, 19 Nov 2009, Am?rico Wang wrote:

> On Wed, Nov 18, 2009 at 02:39:51PM +0000, Alan Cox wrote:
> >scripts/selinux/genheaders/genheaders.c:20: warning: no previous prototype  
> >for ?usage?
> >scripts/selinux/genheaders/genheaders.c:26: warning: no previous prototype
> >for ?stoupperx?
> >
> >Signed-off-by: Alan Cox <alan@linux.intel.com>
> 
> Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
> 

Thanks.


Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next

> >---
> >
> > scripts/selinux/genheaders/genheaders.c |    4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >
> >diff --git a/scripts/selinux/genheaders/genheaders.c b/scripts/selinux/genheaders/genheaders.c
> >index 3b16145..771b86f 100644
> >--- a/scripts/selinux/genheaders/genheaders.c
> >+++ b/scripts/selinux/genheaders/genheaders.c
> >@@ -17,13 +17,13 @@ struct security_class_mapping {
> > 
> > const char *progname;
> > 
> >-void usage(void)
> >+static void usage(void)
> > {
> > 	printf("usage: %s flask.h av_permissions.h\n", progname);
> > 	exit(1);
> > }
> > 
> >-char *stoupperx(const char *s)
> >+static char *stoupperx(const char *s)
> > {
> > 	char *s2 = strdup(s);
> > 	char *p;
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >Please read the FAQ at  http://www.tux.org/lkml/
> 
> -- 
> Live like a child, think like the god.
>  
> 

-- 
James Morris
<jmorris@namei.org>