From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/vgchange.c
Date: 18 Nov 2009 17:20:19 -0000 [thread overview]
Message-ID: <20091118172019.4879.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2009-11-18 17:20:18
Modified files:
. : WHATS_NEW
tools : vgchange.c
Log message:
Never activate hidden volumes directly in vgchange.
All hidden (not visible) volumes should be activated through
other visible volumes.
(There are already exceptions like snapshot, mirror log and image,
which should be cleaned one day...)
This solves problems for future types of hidden volumes,
which can have special meaning and must not be activated implicitly
(e.g. key store volume).
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1315&r2=1.1316
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.89&r2=1.90
--- LVM2/WHATS_NEW 2009/11/18 16:48:10 1.1315
+++ LVM2/WHATS_NEW 2009/11/18 17:20:18 1.1316
@@ -1,5 +1,6 @@
Version 2.02.55 -
===================================
+ Do not activate directly not visible volumes in vgchange.
Fix pvmove region_size oveflow for very large PVs.
Fix lvcreate and lvresize processing of %PVS argument.
Tidy some uses of arg_count and introduce arg_is_set.
--- LVM2/tools/vgchange.c 2009/10/31 17:30:52 1.89
+++ LVM2/tools/vgchange.c 2009/11/18 17:20:18 1.90
@@ -61,6 +61,9 @@
dm_list_iterate_items(lvl, &vg->lvs) {
lv = lvl->lv;
+ if (!lv_is_visible(lv))
+ continue;
+
/* Only request activation of snapshot origin devices */
if ((lv->status & SNAPSHOT) || lv_is_cow(lv))
continue;
next reply other threads:[~2009-11-18 17:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 17:20 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-09-14 18:20 LVM2 ./WHATS_NEW tools/vgchange.c mbroz
2010-10-29 21:15 agk
2010-10-25 10:40 agk
2010-05-24 9:03 zkabelac
2010-05-24 8:59 zkabelac
2009-11-24 16:08 mbroz
2008-06-12 11:49 mbroz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091118172019.4879.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.