All of lore.kernel.org
 help / color / mirror / Atom feed
From: zkabelac@sourceware.org <zkabelac@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW tools/vgchange.c
Date: 24 May 2010 09:03:42 -0000	[thread overview]
Message-ID: <20100524090342.15596.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	zkabelac at sourceware.org	2010-05-24 09:03:39

Modified files:
	.              : WHATS_NEW 
	tools          : vgchange.c 

Log message:
	Replicator: update activate code for vgchange
	
	Activate only the first replicator-dev LV, that activates all other
	related LVs from Replicator. In case of error during this activation,
	it will not retry again for other heads (less confusing error log).

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1593&r2=1.1594
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/vgchange.c.diff?cvsroot=lvm2&r1=1.103&r2=1.104

--- LVM2/WHATS_NEW	2010/05/24 09:01:05	1.1593
+++ LVM2/WHATS_NEW	2010/05/24 09:03:39	1.1594
@@ -1,5 +1,6 @@
 Version 2.02.67 -
 ===============================
+  Activate only first head of Replicator for vgchange -ay.
   Add Replicators' LVs to dtree for activation.
   Avoid print activation message if there is a missing VG (Replicator).
   Fixed scripts/relpath.awk to work in mawk
--- LVM2/tools/vgchange.c	2010/05/24 08:59:30	1.103
+++ LVM2/tools/vgchange.c	2010/05/24 09:03:39	1.104
@@ -104,6 +104,11 @@
 		if ((lv->status & MIRROR_IMAGE) || (lv->status & MIRROR_LOG))
 			continue;
 
+		/* Only request activation of the first replicator-dev LV */
+		/* Avoids retry with all heads in case of failure */
+		if (lv_is_replicator_dev(lv) && (lv != first_replicator_dev(lv)))
+			continue;
+
 		/* Can't deactivate a pvmove LV */
 		/* FIXME There needs to be a controlled way of doing this */
 		if (((activate == CHANGE_AN) || (activate == CHANGE_ALN)) &&



             reply	other threads:[~2010-05-24  9:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-24  9:03 zkabelac [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-14 18:20 LVM2 ./WHATS_NEW tools/vgchange.c mbroz
2010-10-29 21:15 agk
2010-10-25 10:40 agk
2010-05-24  8:59 zkabelac
2009-11-24 16:08 mbroz
2009-11-18 17:20 mbroz
2008-06-12 11:49 mbroz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100524090342.15596.qmail@sourceware.org \
    --to=zkabelac@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.