From: Vasily Khoruzhick <anarsoul@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Ben Dooks <ben@simtec.co.uk>,
dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Arnaud Patard <arnaud.patard@rtp-net.org>,
Simtec Linux Team <linux@simtec.co.uk>
Subject: Re: [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard.
Date: Thu, 19 Nov 2009 10:04:10 +0200 [thread overview]
Message-ID: <200911191004.16315.anarsoul@gmail.com> (raw)
In-Reply-To: <20091118232948.063635416@fluff.org.uk>
[-- Attachment #1: Type: Text/Plain, Size: 373 bytes --]
В сообщении от 19 ноября 2009 1:29:40 автор Ben Dooks написал:
<skipped>
> + /* Initialise registers */
> + if ((info->delay & 0xffff) > 0)
> + writel(info->delay & 0xffff, ts.io + S3C2410_ADCDLY);
As for me, it's not OK to modity ADC-related registers in touchscreen driver,
adc driver should be modified to support delay.
Regards
Vasily
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: anarsoul@gmail.com (Vasily Khoruzhick)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard.
Date: Thu, 19 Nov 2009 10:04:10 +0200 [thread overview]
Message-ID: <200911191004.16315.anarsoul@gmail.com> (raw)
In-Reply-To: <20091118232948.063635416@fluff.org.uk>
? ????????? ?? 19 ?????? 2009 1:29:40 ????? Ben Dooks ???????:
<skipped>
> + /* Initialise registers */
> + if ((info->delay & 0xffff) > 0)
> + writel(info->delay & 0xffff, ts.io + S3C2410_ADCDLY);
As for me, it's not OK to modity ADC-related registers in touchscreen driver,
adc driver should be modified to support delay.
Regards
Vasily
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20091119/5890c791/attachment.sig>
next prev parent reply other threads:[~2009-11-19 8:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091118232939.201290297@fluff.org.uk>
2009-11-18 23:29 ` [patch 1/1] TOUCHSCREEN: S3C24XX touchscreen driver from Arnaud Patard Ben Dooks
2009-11-18 23:29 ` Ben Dooks
2009-11-19 1:45 ` Ramax Lo
2009-11-19 1:45 ` Ramax Lo
2009-11-19 2:59 ` Dmitry Torokhov
2009-11-19 2:59 ` Dmitry Torokhov
2009-11-19 5:47 ` Harald Welte
2009-11-19 5:47 ` Harald Welte
2009-11-19 6:15 ` Shine Liu
2009-11-19 11:34 ` Ben Dooks
2009-11-19 11:34 ` Ben Dooks
2009-11-19 13:52 ` Daniel Silverstone
2009-11-19 13:52 ` Daniel Silverstone
2009-11-19 17:03 ` Dmitry Torokhov
2009-11-19 17:03 ` Dmitry Torokhov
2009-11-19 17:12 ` Russell King - ARM Linux
2009-11-19 17:12 ` Russell King - ARM Linux
2009-11-19 17:48 ` Ben Dooks
2009-11-19 17:48 ` Ben Dooks
2009-11-19 17:14 ` Dmitry Torokhov
2009-11-19 17:14 ` Dmitry Torokhov
2009-11-27 7:31 ` Pavel Machek
2009-11-27 7:31 ` Pavel Machek
2009-11-19 5:46 ` Shine Liu
2009-11-19 5:46 ` Shine Liu
2009-11-19 10:37 ` Mark Brown
2009-11-19 10:37 ` Mark Brown
2009-11-19 12:06 ` Ben Dooks
2009-11-19 12:06 ` Ben Dooks
2009-11-19 8:04 ` Vasily Khoruzhick [this message]
2009-11-19 8:04 ` Vasily Khoruzhick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200911191004.16315.anarsoul@gmail.com \
--to=anarsoul@gmail.com \
--cc=arnaud.patard@rtp-net.org \
--cc=ben@simtec.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.