All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] staging/dream: add missing include files
Date: Thu, 19 Nov 2009 14:56:02 -0800	[thread overview]
Message-ID: <20091119225602.GC18710@kroah.com> (raw)
In-Reply-To: <20091101222717.GB20740@elf.ucw.cz>

On Sun, Nov 01, 2009 at 11:27:17PM +0100, Pavel Machek wrote:
> Add missing files/includes neccessary for Dream compilation.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

This patch includes a file that is not in the drivers/staging/
directory, and it does this Kconfig mess:

> +config GENERIC_GPIO
> +	bool
> +	default y

Which breaks the i386 build.  Don't force on a general config option
like this, that's not nice at all :(

So I'll not apply this one, and the 3/3 patch.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arve Hj?nnev?g <arve@android.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Brian Swetland <swetland@google.com>
Subject: Re: [PATCH 2/3] staging/dream: add missing include files
Date: Thu, 19 Nov 2009 14:56:02 -0800	[thread overview]
Message-ID: <20091119225602.GC18710@kroah.com> (raw)
In-Reply-To: <20091101222717.GB20740@elf.ucw.cz>

On Sun, Nov 01, 2009 at 11:27:17PM +0100, Pavel Machek wrote:
> Add missing files/includes neccessary for Dream compilation.
>     
> Signed-off-by: Pavel Machek <pavel@ucw.cz>

This patch includes a file that is not in the drivers/staging/
directory, and it does this Kconfig mess:

> +config GENERIC_GPIO
> +	bool
> +	default y

Which breaks the i386 build.  Don't force on a general config option
like this, that's not nice at all :(

So I'll not apply this one, and the 3/3 patch.

thanks,

greg k-h

  reply	other threads:[~2009-11-19 22:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-01 22:27 [PATCH 2/3] staging/dream: add missing include files Pavel Machek
2009-11-19 22:56 ` Greg KH [this message]
2009-11-19 22:56   ` Greg KH
2009-11-20 10:57   ` Pavel Machek
2009-11-20 10:57     ` Pavel Machek
2009-11-20 11:07     ` Russell King - ARM Linux
2009-11-20 11:07       ` Russell King - ARM Linux
2009-12-08 10:16       ` Pavel Machek
2009-12-08 10:16         ` Pavel Machek
2009-11-20 15:30     ` Greg KH
2009-11-20 15:30       ` Greg KH
2009-12-06 21:52       ` Pavel Machek
2009-12-06 21:52         ` Pavel Machek
2009-12-12 19:02         ` Greg KH
2009-12-12 19:02           ` Greg KH
2009-12-13 21:15           ` Pavel Machek
2009-12-13 21:15             ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091119225602.GC18710@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.