* [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
@ 2009-11-24 17:00 Anu Krishnamoorthy
2009-11-24 17:29 ` Luis R. Rodriguez
0 siblings, 1 reply; 5+ messages in thread
From: Anu Krishnamoorthy @ 2009-11-24 17:00 UTC (permalink / raw)
To: ath9k-devel
Hi,
?
I had implemented descriptor based TPC(per?packet TPC)?for ath9k by setting the various TxPower control fields within the Tx Descriptor (set11n_txdesc) for the Tx frames. From my testing, for some reason the Tx power values present in the descriptor are not applied by the hardware(I am using ar5416 based card). In contrast, if "iwconfig txpower" (in spite of the known bug) is used(forced to apply by down/up'ing the interface) the power change is noticed from the sniffer.
????? Is any additional setup(transmit queue, txdesc interrupt or hardware setup) needs to be done to force the hardware read and process the tx descriptors? Appreciate if any one could shed more light on it or share their own experience if they had tried to implement this feature.
?
Thanks,
Ramkumar.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20091124/d56372d4/attachment.htm
^ permalink raw reply [flat|nested] 5+ messages in thread* [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
2009-11-24 17:00 [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC Anu Krishnamoorthy
@ 2009-11-24 17:29 ` Luis R. Rodriguez
0 siblings, 0 replies; 5+ messages in thread
From: Luis R. Rodriguez @ 2009-11-24 17:29 UTC (permalink / raw)
To: ath9k-devel
On Tue, Nov 24, 2009 at 09:00:58AM -0800, Anu Krishnamoorthy wrote:
> Hi,
>
> I had implemented descriptor based TPC(per packet TPC) for ath9k by setting the various TxPower control fields within the Tx Descriptor (set11n_txdesc) for the Tx frames. From my testing, for some reason the Tx power values present in the descriptor are not applied by the hardware(I am using ar5416 based card). In contrast, if "iwconfig txpower" (in spite of the known bug) is used(forced to apply by down/up'ing the interface) the power change is noticed from the sniffer.
> Is any additional setup(transmit queue, txdesc interrupt or hardware setup) needs to be done to force the hardware read and process the tx descriptors? Appreciate if any one could shed more light on it or share their own experience if they had tried to implement this feature.
>
> Thanks,
> Ramkumar.
The tx power setting was just set on the sc struct, we likely need a reset so
that when tx power is changed it actually takes effect. There may be an easier
way but I haven't had time to look at this yet.
Luis
^ permalink raw reply [flat|nested] 5+ messages in thread
* [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
@ 2009-11-24 18:04 Anu Krishnamoorthy
2009-11-25 2:33 ` Siva Rama Krishna Rao J. Y.
0 siblings, 1 reply; 5+ messages in thread
From: Anu Krishnamoorthy @ 2009-11-24 18:04 UTC (permalink / raw)
To: ath9k-devel
Hi Luis,
?
Thanks for the reply. I believe the "sc" struct and the curtxpow, config.txpowlimit are used to store/configure the global power(iwconfig <interface> txpower <val>) for all the packets that are transmitted using a wireless interface.
?
If you want a differential treatment(use specific power for only certain packets) then per packet/descriptor based TPC has to be used. The descriptor portion is part of the "transmit buffer" (File:ath9k/xmit.c, Function: ath_tx_start_dma, Argument: bf, attribute bf_desc). There are functions to set various fields of this descriptor struct such as
ath9k_hw_set11n_txdesc, ath9k_hw_set11n_ratescenario (File: ath9k/mac.c) that currently do not make use of these fields.
When I tried to populate the tx power control fields(for a 5416 chip based card)
within the descriptor for every packet buffer, I did not find any effect from the power setting(used the received signal strength for measurement) when I used a sniffer.
Hence I am wondering is more need to be done to force the other functional blocks with the HW to read and apply these descriptors? How to force the HW process the descriptors?
Thanks,
Ramkumar.
--- On Tue, 11/24/09, Luis R. Rodriguez <lrodriguez@atheros.com> wrote:
From: Luis R. Rodriguez <lrodriguez@atheros.com>
Subject: Re: [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
To: "Anu Krishnamoorthy" <anuramku@yahoo.com>
Cc: "ath9k-devel at lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Date: Tuesday, November 24, 2009, 12:29 PM
On Tue, Nov 24, 2009 at 09:00:58AM -0800, Anu Krishnamoorthy wrote:
> Hi,
>
> I had implemented descriptor based TPC(per packet TPC) for ath9k by setting the various TxPower control fields within the Tx Descriptor (set11n_txdesc) for the Tx frames. From my testing, for some reason the Tx power values present in the descriptor are not applied by the hardware(I am using ar5416 based card). In contrast, if "iwconfig txpower" (in spite of the known bug) is used(forced to apply by down/up'ing the interface) the power change is noticed from the sniffer.
>? ? ???Is any additional setup(transmit queue, txdesc interrupt or hardware setup) needs to be done to force the hardware read and process the tx descriptors? Appreciate if any one could shed more light on it or share their own experience if they had tried to implement this feature.
>
> Thanks,
> Ramkumar.
The tx power setting was just set on the sc struct, we likely need a reset so
that when tx power is changed it actually takes effect. There may be an easier
way but I haven't had time to look at this yet.
? Luis
^ permalink raw reply [flat|nested] 5+ messages in thread* [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
2009-11-24 18:04 Anu Krishnamoorthy
@ 2009-11-25 2:33 ` Siva Rama Krishna Rao J. Y.
2009-11-25 14:43 ` Anu Krishnamoorthy
0 siblings, 1 reply; 5+ messages in thread
From: Siva Rama Krishna Rao J. Y. @ 2009-11-25 2:33 UTC (permalink / raw)
To: ath9k-devel
There would be additional hardware register bit setting to enable per packet based TPC. Have you enabled it? I dont remember the exact bit offline.
Regards
Siva
--- On Tue, 11/24/09, Anu Krishnamoorthy <anuramku@yahoo.com> wrote:
From: Anu Krishnamoorthy <anuramku@yahoo.com>
Subject: Re: [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: "ath9k-devel at lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Date: Tuesday, November 24, 2009, 11:34 PM
Hi Luis,
?
Thanks for the reply. I believe the "sc" struct and the curtxpow, config.txpowlimit are used to store/configure the global power(iwconfig <interface> txpower <val>) for all the packets that are transmitted using a wireless interface.
?
If you want a differential treatment(use specific power for only certain packets) then per packet/descriptor based TPC has to be used. The descriptor portion is part of the "transmit buffer" (File:ath9k/xmit.c, Function: ath_tx_start_dma, Argument: bf, attribute bf_desc). There are functions to set various fields of this descriptor struct such as
ath9k_hw_set11n_txdesc, ath9k_hw_set11n_ratescenario (File: ath9k/mac.c) that currently do not make use of these fields.
When I tried to populate the tx power control fields(for a 5416 chip based card)
within the descriptor for every packet buffer, I did not find any effect from the power setting(used the received signal strength for measurement) when I used a sniffer.
Hence I am wondering is more need to be done to force the other functional blocks with the HW to read and apply these descriptors? How to force the HW process the descriptors?
Thanks,
Ramkumar.
--- On Tue, 11/24/09, Luis R. Rodriguez <lrodriguez@atheros.com> wrote:
From: Luis R. Rodriguez <lrodriguez@atheros.com>
Subject: Re: [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
To: "Anu Krishnamoorthy" <anuramku@yahoo.com>
Cc: "ath9k-devel at lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
Date: Tuesday, November 24, 2009, 12:29 PM
On Tue, Nov 24, 2009 at 09:00:58AM -0800, Anu Krishnamoorthy wrote:
> Hi,
>
> I had implemented descriptor based TPC(per packet TPC) for ath9k by setting the various TxPower control fields within the Tx Descriptor (set11n_txdesc) for the Tx frames. From my testing, for some reason the Tx power values present in the descriptor are not applied by the hardware(I am using ar5416 based card). In contrast, if "iwconfig txpower" (in spite of the known bug) is used(forced to apply by down/up'ing the interface) the power change is noticed from the sniffer.
>? ? ???Is any additional setup(transmit queue, txdesc interrupt or hardware setup) needs to be done to force the hardware read and process the tx descriptors? Appreciate if any one could shed more light on it or share their own experience if they had tried to implement this feature.
>
> Thanks,
> Ramkumar.
The tx power setting was just set on the sc struct, we likely need a reset so
that when tx power is changed it actually takes effect. There may be an easier
way but I haven't had time to look at this yet.
? Luis
? ? ?
_______________________________________________
ath9k-devel mailing list
ath9k-devel at lists.ath9k.org
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20091124/f9230630/attachment.htm
^ permalink raw reply [flat|nested] 5+ messages in thread* [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
2009-11-25 2:33 ` Siva Rama Krishna Rao J. Y.
@ 2009-11-25 14:43 ` Anu Krishnamoorthy
0 siblings, 0 replies; 5+ messages in thread
From: Anu Krishnamoorthy @ 2009-11-25 14:43 UTC (permalink / raw)
To: ath9k-devel
Thanks for the reply. I don't know about the hardware register bit. That's the answer I am trying to find out from the forum if you or anyone knows how to enable this feature. I would really appreciate if you could recollect and let me know the hardware register bit you think would do the trick.
Thanks,
Ramkumar.
--- On Tue, 11/24/09, Siva Rama Krishna Rao J. Y. <welcomesiva@yahoo.com> wrote:
> From: Siva Rama Krishna Rao J. Y. <welcomesiva@yahoo.com>
> Subject: Re: [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC
> To: "Luis R. Rodriguez" <lrodriguez@atheros.com>, "Anu Krishnamoorthy" <anuramku@yahoo.com>
> Cc: "ath9k-devel at lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
> Date: Tuesday, November 24, 2009, 9:33 PM
> There
> would be additional hardware register bit setting to enable
> per packet based TPC. Have you enabled it? I dont remember
> the exact bit offline.
>
> Regards
> Siva
>
>
> --- On Tue, 11/24/09, Anu Krishnamoorthy
> <anuramku@yahoo.com> wrote:
>
> From: Anu Krishnamoorthy <anuramku@yahoo.com>
> Subject: Re: [ath9k-devel] ath9k:Descriptor(or Per packet)
> based TPC
> To: "Luis R. Rodriguez"
> <lrodriguez@atheros.com>
> Cc: "ath9k-devel at lists.ath9k.org"
> <ath9k-devel@lists.ath9k.org>
> Date: Tuesday, November 24, 2009, 11:34 PM
>
> Hi Luis,
> ?
> Thanks for the reply. I believe the "sc" struct
> and the curtxpow, config.txpowlimit are used to
> store/configure the global power(iwconfig
> <interface> txpower <val>) for all the packets
> that are transmitted using a wireless interface.
> ?
> If you want a differential treatment(use specific power for
> only certain packets) then per packet/descriptor based TPC
> has to be used. The descriptor portion is part of the
> "transmit buffer" (File:ath9k/xmit.c, Function:
> ath_tx_start_dma, Argument: bf, attribute bf_desc). There
> are functions to set various fields of this descriptor
> struct such as
> ath9k_hw_set11n_txdesc, ath9k_hw_set11n_ratescenario (File:
> ath9k/mac.c) that currently do not make use of these fields.
>
>
> When I tried to populate the tx power control fields(for a
> 5416 chip based card)
> within the descriptor for every packet buffer, I did not
> find any effect from the power setting(used the received
> signal strength for measurement) when I used a sniffer.
> Hence I am wondering is more need to be done to force the
> other functional blocks with the HW to read and
> apply these descriptors? How to force the HW process the
> descriptors?
>
> Thanks,
> Ramkumar.
>
> --- On Tue, 11/24/09, Luis R. Rodriguez <lrodriguez@atheros.com> wrote:
>
>
> From: Luis R. Rodriguez <lrodriguez@atheros.com>
> Subject: Re: [ath9k-devel] ath9k:Descriptor(or Per packet)
> based TPC
> To: "Anu Krishnamoorthy" <anuramku@yahoo.com>
> Cc: "ath9k-devel at lists.ath9k.org" <ath9k-devel@lists.ath9k.org>
> Date: Tuesday, November 24, 2009, 12:29
> PM
>
>
> On Tue, Nov 24, 2009 at 09:00:58AM -0800, Anu
> Krishnamoorthy wrote:
> > Hi,
> >
> > I had implemented descriptor based TPC(per packet TPC)
> for ath9k by setting the various TxPower control fields
> within the Tx Descriptor (set11n_txdesc) for the Tx frames.
> From my testing, for some reason the Tx power values present
> in the descriptor are not applied by the hardware(I am using
> ar5416 based card). In contrast, if "iwconfig
> txpower" (in spite of the known bug) is used(forced to
> apply by down/up'ing the interface) the power change is
> noticed from the sniffer.
> >? ? ???Is any additional
> setup(transmit queue, txdesc interrupt or hardware setup)
> needs to be done to force the hardware read and process the
> tx descriptors? Appreciate if any one could shed more light
> on it or share their own experience if they had tried to
> implement this feature.
> >
> > Thanks,
> > Ramkumar.
>
> The tx power
> setting was just set on the sc struct, we likely need a
> reset so
> that when tx power is changed it actually takes effect.
> There may be an easier
> way but I haven't had time to look at this yet.
>
> ? Luis
>
>
>
> ? ? ?
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>
>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-11-25 14:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-11-24 17:00 [ath9k-devel] ath9k:Descriptor(or Per packet) based TPC Anu Krishnamoorthy
2009-11-24 17:29 ` Luis R. Rodriguez
-- strict thread matches above, loose matches on Subject: below --
2009-11-24 18:04 Anu Krishnamoorthy
2009-11-25 2:33 ` Siva Rama Krishna Rao J. Y.
2009-11-25 14:43 ` Anu Krishnamoorthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.