All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: Gertjan van Wingerde <gwingerde@gmail.com>
Cc: users@rt2x00.serialmonkey.com, linux-wireless@vger.kernel.org,
	Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations.
Date: Wed, 25 Nov 2009 16:48:11 -0500	[thread overview]
Message-ID: <20091125214811.GA22715@tuxdriver.com> (raw)
In-Reply-To: <4B0DA1CC.4020308@gmail.com>

On Wed, Nov 25, 2009 at 10:29:48PM +0100, Gertjan van Wingerde wrote:
> On 11/25/09 20:47, John W. Linville wrote:
> > On Mon, Nov 23, 2009 at 10:44:54PM +0100, Gertjan van Wingerde wrote:
> >> Current rt2x00 drivers may result in a "ieee80211_tx_status: headroom too
> >> small" error message when a frame needs to be properly aligned before
> >> transmitting it.
> >> This is because the space needed to ensure proper alignment isn't
> >> requested from mac80211.
> >> Fix this by adding sufficient amount of alignment space to the amount
> >> of headroom requested for TX frames.
> >>
> >> Reported-by: David Ellingsworth <david@identd.dyndns.org>
> >> Signed-off-by: Gertjan van Wingerde <gwingerde@gmail.com>
> > 
> >   CC [M]  drivers/net/wireless/rt2x00/rt2x00dev.o
> > drivers/net/wireless/rt2x00/rt2x00dev.c: In function ‘rt2x00lib_probe_hw’:
> > drivers/net/wireless/rt2x00/rt2x00dev.c:690: error: ‘IEEE80211_TX_STATUS_HEADROOM’ undeclared (first use in this function)
> > drivers/net/wireless/rt2x00/rt2x00dev.c:690: error: (Each undeclared identifier is reported only once
> > drivers/net/wireless/rt2x00/rt2x00dev.c:690: error: for each function it appears in.)
> > 
> > Did I miss a patch?
> 
> Patch 7 of the series creates that define within mac80211. It is a prerequisite for this patch.

OK, thanks -- somehow it didn't make it out of my mailbox in into
the mbox file I fed to git...

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@tuxdriver.com			might be all we have.  Be ready.

  reply	other threads:[~2009-11-25 22:00 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 21:44 [PATCH v2 0/8] Assorted fixes and cleanups for rt2x00 and mac80211 Gertjan van Wingerde
2009-11-23 21:44 ` [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it Gertjan van Wingerde
2009-11-23 21:44   ` [PATCH v2 2/8] rt2x00: Remove unused variable frame_control from rt2x00mac_tx Gertjan van Wingerde
2009-11-23 21:44     ` [PATCH v2 3/8] rt2x00: Clean up use of rt2x00_intf_is_pci Gertjan van Wingerde
2009-11-23 21:44       ` [PATCH v2 4/8] rt2x00: Fix typo (lengt --> length) in rt2x00queue.c Gertjan van Wingerde
2009-11-23 21:44         ` [PATCH v2 5/8] rt2x00: Whitespace cleanup Gertjan van Wingerde
2009-11-23 21:44           ` [PATCH v2 6/8] rt2x00: Centralize setting of extra TX headroom requested by rt2x00 Gertjan van Wingerde
2009-11-23 21:44             ` [PATCH v2 7/8] mac80211: Add define for TX headroom reserved by mac80211 itself Gertjan van Wingerde
2009-11-23 21:44               ` [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations Gertjan van Wingerde
2009-11-24 17:19                 ` Ivo van Doorn
2009-11-24 19:12                   ` Gertjan van Wingerde
2009-11-24 20:04                     ` Ivo van Doorn
2009-11-25 19:47                 ` John W. Linville
2009-11-25 21:29                   ` Gertjan van Wingerde
2009-11-25 21:48                     ` John W. Linville [this message]
2009-12-20 15:42                 ` [BISECTED] " Markus Baier
2009-12-20 20:20                   ` Gertjan van Wingerde
2009-12-21  0:45                     ` Markus Baier
2009-12-21  6:33                     ` Pavel Roskin
2009-12-21 16:26                       ` Gertjan van Wingerde
2009-12-21 19:17                         ` John W. Linville
2009-12-22  0:22                           ` Gertjan van Wingerde
2009-12-22  5:25                         ` Pavel Roskin
2009-12-22  8:13                           ` Gertjan van Wingerde
2009-12-22 10:55                             ` Markus Baier
2009-12-22 14:18                               ` Gertjan van Wingerde
2009-12-22 15:03                             ` Pavel Roskin
2009-11-23 23:22               ` [PATCH v2 7/8] mac80211: Add define for TX headroom reserved by mac80211 itself Johannes Berg
2009-11-24 17:13             ` [PATCH v2 6/8] rt2x00: Centralize setting of extra TX headroom requested by rt2x00 Ivo van Doorn
2009-11-24 17:13           ` [PATCH v2 5/8] rt2x00: Whitespace cleanup Ivo van Doorn
2009-11-23 22:18   ` [rt2x00-users] [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it David Ellingsworth
2009-11-24 17:12     ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091125214811.GA22715@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=gwingerde@gmail.com \
    --cc=ivdoorn@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=users@rt2x00.serialmonkey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.