All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gertjan van Wingerde <gwingerde@gmail.com>
To: Pavel Roskin <proski@gnu.org>
Cc: Markus Baier <Markus_Baier@web.de>, linux-wireless@vger.kernel.org
Subject: Re: [BISECTED] [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations.
Date: Mon, 21 Dec 2009 17:26:55 +0100	[thread overview]
Message-ID: <4B2FA1CF.1010903@gmail.com> (raw)
In-Reply-To: <20091221013316.nm9belnhywwwsc0w-cebfxv@webmail.spamcop.net>

On 12/21/09 07:33, Pavel Roskin wrote:
> Quoting Gertjan van Wingerde <gwingerde@gmail.com>:
> 
>> On 12/20/09 16:42, Markus Baier wrote:
>>> After my latest git pull to the kernel version 2.6.33-rc1-wl
>>> no client was able to connect to my hostapd (v0.6.9) AP.
>>> I found a lot of the following entries in the syslog:
>>>
>>> wlan0: STA xx:xx:xx:xx:xx:xx
>>> IEEE 802.11: did not acknowledge authentication response
> 
> I'm also having problems with rt2x00 support the current
> wireless-testing, but in the station mode.  The device is using rt61pci
> driver.  Association to an AP with WEP fails.
> 
> [  147.930019] wlan2: direct probe to AP 00:11:6b:28:0b:92 (try 1)
> [  148.130010] wlan2: direct probe to AP 00:11:6b:28:0b:92 (try 2)
> [  148.330009] wlan2: direct probe to AP 00:11:6b:28:0b:92 (try 3)
> [  148.530008] wlan2: direct probe to AP 00:11:6b:28:0b:92 timed out
> [  152.942516] wlan2: direct probe to AP 00:11:6b:28:0b:92 (try 1)
> [  153.142512] wlan2: direct probe to AP 00:11:6b:28:0b:92 (try 2)
> [  153.340011] wlan2: direct probe to AP 00:11:6b:28:0b:92 (try 3)
> [  153.540008] wlan2: direct probe to AP 00:11:6b:28:0b:92 timed out
> 
> It worked fine with wireless-testing when it was 2.6.32 based.
> 
>>> After I removed the lines below in rt2x00dev.c:
> 
> That "patch" is helping me too!  The association is working now.
> 
>> That is very strange as this patch was meant to send TX statuses of
>> frames
>> towards monitor interfaces (which is what hostapd is using).
> 
> I'm not using monitor mode.  I only have one vif in the station mode.
> 
> My debugging shows that the headroom is 0 with the "patch".  Without it,
> the headroom is 17 (13 from IEEE80211_TX_STATUS_HEADROOM plus 4 from
> RT2X00_ALIGN_SIZE).
> 
> Perhaps non-zero headroom is not handled correctly?
> 

Hmmm, perhaps the problem is that the headroom is not a multiple of 4.
Can you check what happens when you set the extra_tx_headroom fixed to e.g. 20?

The driver should be able to handle this, but maybe there is something wrong
with the alignment.

---
Gertjan.

  reply	other threads:[~2009-12-21 16:26 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 21:44 [PATCH v2 0/8] Assorted fixes and cleanups for rt2x00 and mac80211 Gertjan van Wingerde
2009-11-23 21:44 ` [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it Gertjan van Wingerde
2009-11-23 21:44   ` [PATCH v2 2/8] rt2x00: Remove unused variable frame_control from rt2x00mac_tx Gertjan van Wingerde
2009-11-23 21:44     ` [PATCH v2 3/8] rt2x00: Clean up use of rt2x00_intf_is_pci Gertjan van Wingerde
2009-11-23 21:44       ` [PATCH v2 4/8] rt2x00: Fix typo (lengt --> length) in rt2x00queue.c Gertjan van Wingerde
2009-11-23 21:44         ` [PATCH v2 5/8] rt2x00: Whitespace cleanup Gertjan van Wingerde
2009-11-23 21:44           ` [PATCH v2 6/8] rt2x00: Centralize setting of extra TX headroom requested by rt2x00 Gertjan van Wingerde
2009-11-23 21:44             ` [PATCH v2 7/8] mac80211: Add define for TX headroom reserved by mac80211 itself Gertjan van Wingerde
2009-11-23 21:44               ` [PATCH v2 8/8] rt2x00: Properly request tx headroom for alignment operations Gertjan van Wingerde
2009-11-24 17:19                 ` Ivo van Doorn
2009-11-24 19:12                   ` Gertjan van Wingerde
2009-11-24 20:04                     ` Ivo van Doorn
2009-11-25 19:47                 ` John W. Linville
2009-11-25 21:29                   ` Gertjan van Wingerde
2009-11-25 21:48                     ` John W. Linville
2009-12-20 15:42                 ` [BISECTED] " Markus Baier
2009-12-20 20:20                   ` Gertjan van Wingerde
2009-12-21  0:45                     ` Markus Baier
2009-12-21  6:33                     ` Pavel Roskin
2009-12-21 16:26                       ` Gertjan van Wingerde [this message]
2009-12-21 19:17                         ` John W. Linville
2009-12-22  0:22                           ` Gertjan van Wingerde
2009-12-22  5:25                         ` Pavel Roskin
2009-12-22  8:13                           ` Gertjan van Wingerde
2009-12-22 10:55                             ` Markus Baier
2009-12-22 14:18                               ` Gertjan van Wingerde
2009-12-22 15:03                             ` Pavel Roskin
2009-11-23 23:22               ` [PATCH v2 7/8] mac80211: Add define for TX headroom reserved by mac80211 itself Johannes Berg
2009-11-24 17:13             ` [PATCH v2 6/8] rt2x00: Centralize setting of extra TX headroom requested by rt2x00 Ivo van Doorn
2009-11-24 17:13           ` [PATCH v2 5/8] rt2x00: Whitespace cleanup Ivo van Doorn
2009-11-23 22:18   ` [rt2x00-users] [PATCH v2 1/8] rt2x00: Only initialize HT on rt2800 devices that support it David Ellingsworth
2009-11-24 17:12     ` Ivo van Doorn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2FA1CF.1010903@gmail.com \
    --to=gwingerde@gmail.com \
    --cc=Markus_Baier@web.de \
    --cc=linux-wireless@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.