All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Benjamin Herrenschmidt <benh@au1.ibm.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org,
	Arun R Bharadwaj <arun@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v5 2/4] pSeries: Add hooks to put the CPU into an appropriate offline state
Date: Thu, 26 Nov 2009 16:10:36 +1100	[thread overview]
Message-ID: <20091126051036.GA12086@kryten> (raw)
In-Reply-To: <20091030052253.25493.65063.stgit@sofia.in.ibm.com>


Hi Gautham,

> +	call_status = rtas_call(rtas_token("ibm,get-system-parameter"), 3, 1,
> +				NULL,
> +				CEDE_LATENCY_TOKEN,
> +				__pa(cede_parameters),
> +				CEDE_LATENCY_PARAM_MAX_LENGTH);
> +
> +	if (call_status != 0)
> +		printk(KERN_INFO "CEDE_LATENCY: \
> +			%s %s Error calling get-system-parameter(0x%x)\n",
> +			__FILE__, __func__, call_status);
> +	else
> +		printk(KERN_INFO "CEDE_LATENCY: \
> +			get-system-parameter successful.\n");

I'm seeing this on a POWER6 box:


CEDE_LATENCY: 			arch/powerpc/platforms/pseries/hotplug-cpu.c parse_cede_parameters Error calling get-system-parameter(0xfffffffd)


Seems overly verbose. Do we need to print success/fail on this call? Perhaps
a summary line if anything during initialisation failed:

Cede latency not supported

and

Cede latency supported

If it all worked.

Anton

WARNING: multiple messages have this Message-ID (diff)
From: Anton Blanchard <anton@samba.org>
To: Gautham R Shenoy <ego@in.ibm.com>
Cc: Nathan Fontenot <nfont@austin.ibm.com>,
	Benjamin Herrenschmidt <benh@au1.ibm.com>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org,
	Arun R Bharadwaj <arun@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH v5 2/4] pSeries: Add hooks to put the CPU into an appropriate offline state
Date: Thu, 26 Nov 2009 16:10:36 +1100	[thread overview]
Message-ID: <20091126051036.GA12086@kryten> (raw)
In-Reply-To: <20091030052253.25493.65063.stgit@sofia.in.ibm.com>


Hi Gautham,

> +	call_status = rtas_call(rtas_token("ibm,get-system-parameter"), 3, 1,
> +				NULL,
> +				CEDE_LATENCY_TOKEN,
> +				__pa(cede_parameters),
> +				CEDE_LATENCY_PARAM_MAX_LENGTH);
> +
> +	if (call_status != 0)
> +		printk(KERN_INFO "CEDE_LATENCY: \
> +			%s %s Error calling get-system-parameter(0x%x)\n",
> +			__FILE__, __func__, call_status);
> +	else
> +		printk(KERN_INFO "CEDE_LATENCY: \
> +			get-system-parameter successful.\n");

I'm seeing this on a POWER6 box:


CEDE_LATENCY: 			arch/powerpc/platforms/pseries/hotplug-cpu.c parse_cede_parameters Error calling get-system-parameter(0xfffffffd)


Seems overly verbose. Do we need to print success/fail on this call? Perhaps
a summary line if anything during initialisation failed:

Cede latency not supported

and

Cede latency supported

If it all worked.

Anton

  reply	other threads:[~2009-11-26  5:10 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-30  5:22 [PATCH v5 0/4] pseries: Add cede support for cpu-offline Gautham R Shenoy
2009-10-30  5:22 ` Gautham R Shenoy
2009-10-30  5:22 ` [PATCH v5 1/4] pSeries: extended_cede_processor() helper function Gautham R Shenoy
2009-10-30  5:22   ` Gautham R Shenoy
2009-10-30  5:22 ` [PATCH v5 2/4] pSeries: Add hooks to put the CPU into an appropriate offline state Gautham R Shenoy
2009-10-30  5:22   ` Gautham R Shenoy
2009-11-26  5:10   ` Anton Blanchard [this message]
2009-11-26  5:10     ` Anton Blanchard
2009-10-30  5:22 ` [PATCH v5 3/4] pseries: Add code to online/offline CPUs of a DLPAR node Gautham R Shenoy
2009-10-30  5:22   ` Gautham R Shenoy
2009-10-30  5:23 ` [PATCH v5 4/4] pseries: Serialize cpu hotplug operations during deactivate Vs deallocate Gautham R Shenoy
2009-10-30  5:23   ` Gautham R Shenoy
2009-11-11 12:01 ` [PATCH v5 0/4] pseries: Add cede support for cpu-offline Gautham R Shenoy
2009-11-11 12:01   ` Gautham R Shenoy
2009-11-11 13:25 ` Peter Zijlstra
2009-11-11 13:25   ` Peter Zijlstra
2009-11-11 21:35   ` Benjamin Herrenschmidt
2009-11-11 21:35     ` Benjamin Herrenschmidt
2009-11-11 21:45     ` Peter Zijlstra
2009-11-11 21:45       ` Peter Zijlstra
2009-11-24  3:35 ` Benjamin Herrenschmidt
2009-11-24  3:35   ` Benjamin Herrenschmidt
2009-11-24  5:25   ` Vaidyanathan Srinivasan
2009-11-24  5:25     ` Vaidyanathan Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091126051036.GA12086@kryten \
    --to=anton@samba.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=akpm@linux-foundation.org \
    --cc=arun@linux.vnet.ibm.com \
    --cc=benh@au1.ibm.com \
    --cc=ego@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.