From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Torsten Fleischer <to-fleischer@t-online.de>,
spi-devel-general@lists.sourceforge.net,
linuxppc-dev@lists.ozlabs.org
Subject: Re: spi_mpc8xxx.c: chip select polarity problem
Date: Thu, 26 Nov 2009 21:41:57 +0300 [thread overview]
Message-ID: <20091126184157.GA16607@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <fa686aa40911261016p489981a2g1fac393264c4d1c7@mail.gmail.com>
On Thu, Nov 26, 2009 at 11:16:34AM -0700, Grant Likely wrote:
[...]
> The spi-cs-high property is defined in
> Documentation/powerpc/dts-bindings/spi-bus.txt, but it definitely was
> a mistake
Yup.
> Currently the spi-cs-high property is parsed in the
> of_register_spi_devices() function, but the CS polarity needs to be
> known before registering devices. It needs to be factored out into
> another utility function callable by spi bus drivers so that it can
> get polarity data at probe time.
Untill we have this, Torsten's patch is a real improvement, and
works for non-broken hw/fw.
So I think it should be applied.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2009-11-26 18:41 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-16 16:42 spi_mpc8xxx.c: chip select polarity problem Torsten Fleischer
2009-11-16 17:10 ` Anton Vorontsov
2009-11-16 18:00 ` Anton Vorontsov
2009-11-17 20:09 ` Torsten Fleischer
2009-11-17 20:22 ` Anton Vorontsov
2009-11-17 23:28 ` Anton Vorontsov
2009-11-18 16:20 ` Torsten Fleischer
2009-11-18 23:29 ` Anton Vorontsov
2009-11-21 8:45 ` Grant Likely
2009-11-21 16:08 ` Torsten Fleischer
2009-11-25 0:33 ` Grant Likely
2009-11-25 20:41 ` Torsten Fleischer
2009-11-25 22:11 ` Grant Likely
2009-11-25 22:11 ` Grant Likely
2009-11-26 12:12 ` Anton Vorontsov
2009-11-26 12:12 ` Anton Vorontsov
2009-11-26 17:27 ` Torsten Fleischer
2009-11-26 18:18 ` Grant Likely
2009-11-26 18:18 ` Grant Likely
2009-11-26 18:16 ` Grant Likely
2009-11-26 18:16 ` Grant Likely
2009-11-26 18:41 ` Anton Vorontsov [this message]
2009-11-26 18:50 ` Grant Likely
2009-11-26 18:50 ` Grant Likely
2009-11-26 19:01 ` Anton Vorontsov
2009-11-26 19:01 ` Anton Vorontsov
2009-11-26 19:17 ` Grant Likely
2009-11-26 19:17 ` Grant Likely
2009-12-09 15:49 ` Torsten Fleischer
2009-12-09 17:46 ` Grant Likely
2009-12-09 19:13 ` Torsten Fleischer
2009-12-14 16:54 ` Torsten Fleischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126184157.GA16607@oksana.dev.rtsoft.ru \
--to=avorontsov@ru.mvista.com \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=to-fleischer@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.