From: Pete Zaitcev <zaitcev@redhat.com>
To: cmccabe@alumni.cmu.edu
Cc: Project Hail List <hail-devel@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>, cmccabe <cmccabe@alumni.cmu.edu>
Subject: Re: [PATCH] Some minor CLD test program fixes
Date: Sat, 28 Nov 2009 01:17:06 -0700 [thread overview]
Message-ID: <20091128011706.5a2e2cd8@redhat.com> (raw)
In-Reply-To: <1259364036-19428-1-git-send-email-cmccabe@alumni.cmu.edu>
On Fri, 27 Nov 2009 15:20:36 -0800
cmccabe@alumni.cmu.edu wrote:
> When doing a raw read(2) in cld_readport(), resume after EINTR.
> Also resume if we read less than the requested amount.
> if ((fd = open(fname, O_RDONLY)) == -1)
> return -errno;
> - rc = read(fd, buf, LEN);
> + memset(buf, 0, sizeof(buf));
> + rc = safe_read(fd, buf, LEN);
> close(fd);
I don't think it's necessary when reading from a file.
> In the test programs, call g_thread_init() before cldc_init().
> cldc_init has a
> stern warning to "call cldc_init after g_thread_init, if present."
This may be a prudent thing to do, I just forgot about the
tests when I planned this.
-- Pete
next prev parent reply other threads:[~2009-11-28 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-27 23:20 [PATCH] Some minor CLD test program fixes cmccabe
2009-11-28 8:17 ` Pete Zaitcev [this message]
2009-11-28 9:23 ` Jeff Garzik
2009-11-28 10:03 ` Colin McCabe
2009-11-28 10:04 ` Jeff Garzik
2009-11-28 2:21 ` [PATCH v2 1/2] cld: in tests, call g_thread_init before cld_init Colin McCabe
2009-11-28 10:26 ` Colin McCabe
2009-11-28 10:32 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091128011706.5a2e2cd8@redhat.com \
--to=zaitcev@redhat.com \
--cc=cmccabe@alumni.cmu.edu \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.