All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: cmccabe@alumni.cmu.edu
Cc: Project Hail List <hail-devel@vger.kernel.org>,
	Pete Zaitcev <zaitcev@redhat.com>
Subject: Re: [PATCH] Some minor CLD test program fixes
Date: Sat, 28 Nov 2009 05:04:17 -0500	[thread overview]
Message-ID: <4B10F5A1.8040305@garzik.org> (raw)
In-Reply-To: <1259364036-19428-1-git-send-email-cmccabe@alumni.cmu.edu>

On 11/27/2009 06:20 PM, cmccabe@alumni.cmu.edu wrote:
> From: cmccabe<cmccabe@alumni.cmu.edu>
>
> Hi all! Here is a small patch to the CLD test programs...
>
> When doing a raw read(2) in cld_readport(), resume after EINTR. Also resume if
> we read less than the requested amount.
>
> In the test programs, call g_thread_init() before cldc_init(). cldc_init has a
> stern warning to "call cldc_init after g_thread_init, if present."
> ---
>   lib/common.c           |   37 ++++++++++++++++++++++++++++++++++---
>   test/it-works.c        |    1 +
>   test/load-file-event.c |    1 +
>   test/lock-file-event.c |    1 +
>   test/save-file-event.c |    1 +
>   5 files changed, 38 insertions(+), 3 deletions(-)

Oh, and two procedural notes:

1) As noted in doc/contributions.txt (and like the Linux kernel), all 
patches must include a Signed-off-by line.  This normally is the last 
line in the extended patch description, found in the email body.

2) Adding "From: ..." is rather pointless in this case, because the 
From: feature is used to denote an author other than yourself.  The 
default is taken from the email RFC822 headers, which appear to be fine 
in your case.  In the kernel, Andrew Morton uses this feature to 
indicate the original patch author, when he mails a huge swath of 
patches to Linus for application.

	Jeff



  parent reply	other threads:[~2009-11-28 10:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-27 23:20 [PATCH] Some minor CLD test program fixes cmccabe
2009-11-28  8:17 ` Pete Zaitcev
2009-11-28  9:23 ` Jeff Garzik
2009-11-28 10:03   ` Colin McCabe
2009-11-28 10:04 ` Jeff Garzik [this message]
2009-11-28  2:21   ` [PATCH v2 1/2] cld: in tests, call g_thread_init before cld_init Colin McCabe
2009-11-28 10:26     ` Colin McCabe
2009-11-28 10:32     ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B10F5A1.8040305@garzik.org \
    --to=jeff@garzik.org \
    --cc=cmccabe@alumni.cmu.edu \
    --cc=hail-devel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.