From: Alasdair G Kergon <agk@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Optionally abort on internal errors.
Date: Mon, 30 Nov 2009 10:01:33 +0000 [thread overview]
Message-ID: <20091130100133.GC22702@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <4B12DAC3.2030305@redhat.com>
On Sun, Nov 29, 2009 at 09:34:11PM +0100, Milan Broz wrote:
> + if (level <= _LOG_ERR && !strncmp(format, "Internal error:",
> + strlen("Internal error:")))
> (why strlen? just len or better #define the string)
#define LOG_INTERNAL_ERR "Internal error: "
These messages may occur at any log level.
In normal circumstances not all of them prevent the program proceeding,
but all should be fatal if this option is set.
> - maybe only activate that when in debug (verbose mode)?
Too confusing. Control via --config should be sufficient for now.
Alasdair
next prev parent reply other threads:[~2009-11-30 10:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 19:26 [PATCH] Optionally abort on internal errors Petr Rockai
2009-11-29 20:34 ` Milan Broz
2009-11-30 10:01 ` Alasdair G Kergon [this message]
2009-11-30 9:50 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091130100133.GC22702@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.