From: Milan Broz <mbroz@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] Optionally abort on internal errors.
Date: Sun, 29 Nov 2009 21:34:11 +0100 [thread overview]
Message-ID: <4B12DAC3.2030305@redhat.com> (raw)
In-Reply-To: <87ocml3zeu.fsf@twilight.int.mornfall.net.>
On 11/29/2009 08:26 PM, Petr Rockai wrote:
> a fairly straightforward patch adding a configure option that will
> abort() the process in case it encounters an internal
> error. Undocumented so far and not sure it's appropriate to expose --
> but maybe we have a policy of no undocumented options?
I like that idea, very useful for test suite.
ACK from me.
just some nitpicking changes like
+ if (level <= _LOG_ERR && !strncmp(format, "Internal error:",
+ strlen("Internal error:")))
(why strlen? just len or better #define the string)
- should it be in log section (global?)
- maybe only activate that when in debug (verbose mode)?
Milan
next prev parent reply other threads:[~2009-11-29 20:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-29 19:26 [PATCH] Optionally abort on internal errors Petr Rockai
2009-11-29 20:34 ` Milan Broz [this message]
2009-11-30 10:01 ` Alasdair G Kergon
2009-11-30 9:50 ` Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B12DAC3.2030305@redhat.com \
--to=mbroz@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.