From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/activate/activate.c
Date: 1 Dec 2009 19:10:24 -0000 [thread overview]
Message-ID: <20091201191024.9255.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2009-12-01 19:10:23
Modified files:
. : WHATS_NEW
lib/activate : activate.c
Log message:
Fix memory leak in lv_info_by_lvid
The lv_from_lvid calls internally vg_read(),
we must release vg structure afterwards.
Code is called only from clvmd.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1335&r2=1.1336
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.158&r2=1.159
--- LVM2/WHATS_NEW 2009/11/27 14:35:38 1.1335
+++ LVM2/WHATS_NEW 2009/12/01 19:10:23 1.1336
@@ -1,5 +1,6 @@
Version 2.02.57 -
====================================
+ Fix clvmd memory leak in lv_info_by_lvid.
Do not allow creating mirrors of more than 8 images.
Use locking_type 3 (compiled in cluster locking) in lvmconf.
Remove duplicate dm_list macros and functions.
--- LVM2/lib/activate/activate.c 2009/10/30 13:07:49 1.158
+++ LVM2/lib/activate/activate.c 2009/12/01 19:10:23 1.159
@@ -486,12 +486,16 @@
int lv_info_by_lvid(struct cmd_context *cmd, const char *lvid_s,
struct lvinfo *info, int with_open_count, int with_read_ahead)
{
+ int r;
struct logical_volume *lv;
if (!(lv = lv_from_lvid(cmd, lvid_s, 0)))
return 0;
- return _lv_info(cmd, lv, 0, info, with_open_count, with_read_ahead, 0);
+ r = _lv_info(cmd, lv, 0, info, with_open_count, with_read_ahead, 0);
+ vg_release(lv->vg);
+
+ return r;
}
/*
next reply other threads:[~2009-12-01 19:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 19:10 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 22:16 LVM2 ./WHATS_NEW lib/activate/activate.c zkabelac
2011-02-18 14:26 zkabelac
2010-08-16 23:29 agk
2010-07-12 11:37 prajnoha
2010-05-21 14:34 zkabelac
2010-01-27 13:24 mbroz
2009-12-03 19:23 mbroz
2009-10-30 13:07 agk
2009-09-29 18:50 agk
2009-09-29 15:17 mbroz
2007-08-01 20:29 jbrassow
2006-12-20 16:19 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091201191024.9255.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.