From: agk@sourceware.org <agk@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/activate/activate.c
Date: 16 Aug 2010 23:29:10 -0000 [thread overview]
Message-ID: <20100816232910.28280.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: agk at sourceware.org 2010-08-16 23:29:10
Modified files:
. : WHATS_NEW
lib/activate : activate.c
Log message:
Don't really change monitoring status when in test mode.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1704&r2=1.1705
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/activate/activate.c.diff?cvsroot=lvm2&r1=1.174&r2=1.175
--- LVM2/WHATS_NEW 2010/08/16 22:54:35 1.1704
+++ LVM2/WHATS_NEW 2010/08/16 23:29:09 1.1705
@@ -1,5 +1,6 @@
Version 2.02.73 -
================================
+ Don't really change monitoring status when in test mode.
Fix some exit statuses when starting/stopping monitoring fails.
Enable snapshot monitoring by default when dmeventd is enabled.
Move cloned libdevmapper-event client code from segments into lib/activate.
--- LVM2/lib/activate/activate.c 2010/08/16 22:54:36 1.174
+++ LVM2/lib/activate/activate.c 2010/08/16 23:29:10 1.175
@@ -940,7 +940,12 @@
if (!monitor_fn)
continue;
- log_verbose("%sonitoring %s/%s", monitor ? "M" : "Not m", lv->vg->name, lv->name);
+ log_verbose("%sonitoring %s/%s%s", monitor ? "M" : "Not m", lv->vg->name, lv->name,
+ test_mode() ? " [Test mode: skipping this]" : "");
+
+ /* FIXME Test mode should really continue a bit further. */
+ if (test_mode())
+ continue;
/* FIXME specify events */
if (!monitor_fn(seg, 0)) {
@@ -964,7 +969,8 @@
sleep(1);
}
- r = (monitored && monitor) || (!monitored && !monitor);
+ if (r)
+ r = (monitored && monitor) || (!monitored && !monitor);
}
return r;
next reply other threads:[~2010-08-16 23:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 23:29 agk [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-25 22:16 LVM2 ./WHATS_NEW lib/activate/activate.c zkabelac
2011-02-18 14:26 zkabelac
2010-07-12 11:37 prajnoha
2010-05-21 14:34 zkabelac
2010-01-27 13:24 mbroz
2009-12-03 19:23 mbroz
2009-12-01 19:10 mbroz
2009-10-30 13:07 agk
2009-09-29 18:50 agk
2009-09-29 15:17 mbroz
2007-08-01 20:29 jbrassow
2006-12-20 16:19 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100816232910.28280.qmail@sourceware.org \
--to=agk@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.