All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Stephenson <wstephenson-RoXCvvDuEio@public.gmane.org>
To: kde-hardware-devel-RoXCvvDuEio@public.gmane.org
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
	Corentin Chary
	<corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	dbus-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	Dmitry Torokhov
	<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	hal-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
	linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	networkmanager-list-rDKQcyrBJuzYtjvyW6yDsg@public.gmane.org,
	Len Brown <lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [Kde-hardware-devel] [PATCH 32/33] input: add KEY_WIRELESS_CYCLE
Date: Thu, 3 Dec 2009 12:23:04 +0100	[thread overview]
Message-ID: <200912031223.04419.wstephenson@kde.org> (raw)
In-Reply-To: <1259833412.12843.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>

On Thursday 03 December 2009 10:43:32 Johannes Berg wrote:
> On Thu, 2009-12-03 at 10:22 +0100, Corentin Chary wrote:
> > Dear system infrastructure people,
> > Do you think a KEY_WIRELESS_CYCLE key would have any application ?
> 
> Not really.
> 
> The naming of the key ultimately will not matter one bit, because it'll
> be misnamed on most platforms anyway, unless we want to do DMI matching
> or something to name the key. And even then, if there's a wifi key but
> no bluetooth key, users may prefer to have the wifi key act as a cycle
> key instead.
> 
> Therefore, this ought to all be policy in the rfkill daemon.
> rfkill-input will be going away as soon as somebody writes a simple
> daemon that allows doing such things, I really don't see us adding
> support for a cycle key to the kernel code, and for the userspace code
> it doesn't matter since users will configure it independent of the key
> code anyway.

This sounds reasonable to me, as the wireless guy in the KDE camp.  I don't 
want to have to handle these keypresses in a user session anyway - I prefer 
that NetworkManager picks up on them and notifies the client of the state 
change.

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Will Stephenson <wstephenson@kde.org>
To: kde-hardware-devel@kde.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
	Corentin Chary <corentin.chary@gmail.com>,
	dbus@lists.freedesktop.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-wireless@vger.kernel.org, hal@lists.freedesktop.org,
	linux-acpi@vger.kernel.org, linux-input@vger.kernel.org,
	networkmanager-list@gnome.org, Len Brown <lenb@kernel.org>
Subject: Re: [Kde-hardware-devel] [PATCH 32/33] input: add KEY_WIRELESS_CYCLE
Date: Thu, 3 Dec 2009 12:23:04 +0100	[thread overview]
Message-ID: <200912031223.04419.wstephenson@kde.org> (raw)
In-Reply-To: <1259833412.12843.7.camel@johannes.local>

On Thursday 03 December 2009 10:43:32 Johannes Berg wrote:
> On Thu, 2009-12-03 at 10:22 +0100, Corentin Chary wrote:
> > Dear system infrastructure people,
> > Do you think a KEY_WIRELESS_CYCLE key would have any application ?
> 
> Not really.
> 
> The naming of the key ultimately will not matter one bit, because it'll
> be misnamed on most platforms anyway, unless we want to do DMI matching
> or something to name the key. And even then, if there's a wifi key but
> no bluetooth key, users may prefer to have the wifi key act as a cycle
> key instead.
> 
> Therefore, this ought to all be policy in the rfkill daemon.
> rfkill-input will be going away as soon as somebody writes a simple
> daemon that allows doing such things, I really don't see us adding
> support for a cycle key to the kernel code, and for the userspace code
> it doesn't matter since users will configure it independent of the key
> code anyway.

This sounds reasonable to me, as the wireless guy in the KDE camp.  I don't 
want to have to handle these keypresses in a user session anyway - I prefer 
that NetworkManager picks up on them and notifies the client of the state 
change.

Will

  parent reply	other threads:[~2009-12-03 11:23 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-03  7:44 [PATCH 00/33] acpi4asus updates for 2.6.33 Corentin Chary
2009-12-03  7:44 ` [PATCH 01/33] eeepc-laptop: disp attribute should be write-only Corentin Chary
2009-12-03  7:44   ` [PATCH 02/33] asus-laptop: Remove redundant NULL checks Corentin Chary
2009-12-03  7:44     ` [PATCH 03/33] asus-acpi: " Corentin Chary
2009-12-03  7:44       ` [PATCH 04/33] asus-laptop: Remove uneccesary acpi_disabled check Corentin Chary
2009-12-03  7:44         ` [PATCH 05/33] asus-acpi: Remove uneccesary acpi_disabled checks Corentin Chary
2009-12-03  7:44           ` [PATCH 06/33] asus-acpi: set acpi_driver.owner Corentin Chary
2009-12-03  7:44             ` [PATCH 07/33] asus-laptop: " Corentin Chary
2009-12-03  7:44               ` [PATCH 08/33] eeepc-laptop: add touchpad led Corentin Chary
2009-12-03  7:44                 ` [PATCH 09/33] eeepc-laptop: Remove redundant NULL checks Corentin Chary
2009-12-03  7:44                   ` [PATCH 10/33] eeepc-laptop: Remove uneccesary acpi_disabled check Corentin Chary
2009-12-03  7:44                     ` [PATCH 11/33] eeepc-laptop: set acpi_driver.owner Corentin Chary
2009-12-03  7:44                       ` [PATCH 12/33] eeepc-laptop: fix value of pwm1_enable to match documentation Corentin Chary
2009-12-03  7:44                         ` [PATCH 13/33] eeepc-laptop: fix led initialization order Corentin Chary
2009-12-03  7:44                           ` [PATCH 14/33] eeepc-laptop: fix potential leak (led_init() failure) Corentin Chary
2009-12-03  7:44                             ` [PATCH 15/33] eeepc-laptop: fix set_acpi() to return non-zero on failure Corentin Chary
2009-12-03  7:45                               ` [PATCH 16/33] eeepc-laptop: remove redundant NULL checks Corentin Chary
2009-12-03  7:45                                 ` [PATCH 17/33] eeepc-laptop: no need to check argument of set_brightness() Corentin Chary
2009-12-03  7:45                                   ` [PATCH 18/33] eeepc-laptop: simplify acpi initialization Corentin Chary
2009-12-03  7:45                                     ` [PATCH 19/33] eeepc-laptop: simplify how the hwmon device reads values from the EC Corentin Chary
2009-12-03  7:45                                       ` [PATCH 20/33] eeepc-laptop: refactor notifications Corentin Chary
2009-12-03  7:45                                         ` [PATCH 21/33] eeepc-laptop: move platform driver registration out of eeepc_hotk_add() Corentin Chary
2009-12-03  7:45                                           ` [PATCH 22/33] eeepc-laptop: move platform device initialisation to a separate function Corentin Chary
2009-12-03  7:45                                             ` [PATCH 23/33] eeepc-laptop: code movement Corentin Chary
2009-12-03  7:45                                               ` [PATCH 24/33] eeepc-laptop: revise names Corentin Chary
2009-12-03  7:45                                                 ` [PATCH 25/33] eeepc-laptop: callbacks should use "driver data" parameter or field Corentin Chary
2009-12-03  7:45                                                   ` [PATCH 26/33] asus-laptop: use KEY_F13 to map "Disable Touchpad" event Corentin Chary
2009-12-03  7:45                                                     ` [PATCH 27/33] asus-laptop: add Lenovo SL hotkey support Corentin Chary
2009-12-03  7:45                                                       ` [PATCH 28/33] asus-laptop: Add wlan switch found on V6V Corentin Chary
2009-12-03  7:45                                                         ` [PATCH 29/33] eeepc-laptop: map keys found on newer eeepc Corentin Chary
2009-12-03  7:45                                                           ` [PATCH 30/33] eeepc-laptop: fix coding style Corentin Chary
2009-12-03  7:45                                                             ` [PATCH 31/33] eeepc-laptop: re-add check for eeepc->backlight == NULL Corentin Chary
2009-12-03  7:45                                                               ` [PATCH 32/33] input: add KEY_WIRELESS_CYCLE Corentin Chary
2009-12-03  7:45                                                                 ` [PATCH 33/33] asus-laptop: schedule display_get and lcd_switch for removal Corentin Chary
2009-12-03  7:54                                                                 ` [PATCH 32/33] input: add KEY_WIRELESS_CYCLE Dmitry Torokhov
2009-12-03  8:12                                                                   ` Corentin Chary
2009-12-03  8:21                                                                     ` Dmitry Torokhov
2009-12-03  8:51                                                                       ` Corentin Chary
2009-12-03  8:57                                                                         ` Dmitry Torokhov
2009-12-03  9:22                                                                           ` Corentin Chary
2009-12-03  9:43                                                                             ` Johannes Berg
     [not found]                                                                               ` <1259833412.12843.7.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-12-03 11:23                                                                                 ` Will Stephenson [this message]
2009-12-03 11:23                                                                                   ` [Kde-hardware-devel] " Will Stephenson
2009-12-03 15:01                                                                             ` Matthew Garrett
2009-12-06  6:58                                                                     ` Andrey Rahmatullin
2009-12-06  7:17                                                                       ` Dmitry Torokhov
2009-12-06  8:21                                                                         ` Corentin Chary
2009-12-06 14:54                                                                           ` Matthew Garrett
2009-12-07 11:47                                                                             ` Henrique de Moraes Holschuh
2009-12-07 12:55                                                                               ` Matthew Garrett
2009-12-07 13:23                                                                                 ` Henrique de Moraes Holschuh
2009-12-07 14:20                                                                                   ` Matthew Garrett
2009-12-07 17:02                                                                                     ` Henrique de Moraes Holschuh
2009-12-03 10:54                                                                   ` Henrique de Moraes Holschuh
2009-12-09 21:04 ` [PATCH 00/33] acpi4asus updates for 2.6.33 Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912031223.04419.wstephenson@kde.org \
    --to=wstephenson-roxcvvdueio@public.gmane.org \
    --cc=corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=dbus-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=hal-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    --cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
    --cc=kde-hardware-devel-RoXCvvDuEio@public.gmane.org \
    --cc=lenb-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=networkmanager-list-rDKQcyrBJuzYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.