All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	Alex Chiang <achiang@hp.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"Li, Haicheng" <haicheng.li@intel.com>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC] print symbolic page flag names in bad_page()
Date: Mon, 7 Dec 2009 06:38:06 +0100	[thread overview]
Message-ID: <20091207053806.GA17052@elte.hu> (raw)
In-Reply-To: <20091206230016.GA18989@one.firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> > So how about this patch?
> 
> I like it. Decoding the flags by hand is always a very unpleasant 
> experience. Bonus: dump_page can be called from kgdb too.

Guys, please do more review:

> +void dump_page(struct page *page)
> +{
> +     char buf[1024];

NAK. This code causes a brutal, +1K kernel stack footprint spike that 
can crash a system _precisely_ when we are trying to dump a (presumably 
rare) condition.

> +EXPORT_SYMBOL(dump_page);

( Small detail: such exports are EXPORT_SYMBOL_GPL - we dont want random 
  external modules start using it. )

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Andi Kleen <andi@firstfloor.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
	Alex Chiang <achiang@hp.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"Li, Haicheng" <haicheng.li@intel.com>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	Christoph Lameter <cl@linux-foundation.org>,
	Rik van Riel <riel@redhat.com>, Mel Gorman <mel@csn.ul.ie>,
	KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC] print symbolic page flag names in bad_page()
Date: Mon, 7 Dec 2009 06:38:06 +0100	[thread overview]
Message-ID: <20091207053806.GA17052@elte.hu> (raw)
In-Reply-To: <20091206230016.GA18989@one.firstfloor.org>


* Andi Kleen <andi@firstfloor.org> wrote:

> > So how about this patch?
> 
> I like it. Decoding the flags by hand is always a very unpleasant 
> experience. Bonus: dump_page can be called from kgdb too.

Guys, please do more review:

> +void dump_page(struct page *page)
> +{
> +     char buf[1024];

NAK. This code causes a brutal, +1K kernel stack footprint spike that 
can crash a system _precisely_ when we are trying to dump a (presumably 
rare) condition.

> +EXPORT_SYMBOL(dump_page);

( Small detail: such exports are EXPORT_SYMBOL_GPL - we dont want random 
  external modules start using it. )

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2009-12-07  5:38 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 21:29 [PATCH] page-types: kernel pageflags mode Alex Chiang
2009-12-04 21:29 ` Alex Chiang
2009-12-04 22:17 ` Randy Dunlap
2009-12-04 22:17   ` Randy Dunlap
2009-12-06  3:46 ` [RFC] print symbolic page flag names in bad_page() Wu Fengguang
2009-12-06  3:46   ` Wu Fengguang
2009-12-06 23:00   ` Andi Kleen
2009-12-06 23:00     ` Andi Kleen
2009-12-07  2:01     ` Alex Chiang
2009-12-07  2:01       ` Alex Chiang
2009-12-07  2:02     ` Wu Fengguang
2009-12-07  2:02       ` Wu Fengguang
2009-12-07  5:38     ` Ingo Molnar [this message]
2009-12-07  5:38       ` Ingo Molnar
2009-12-07  9:30   ` Mel Gorman
2009-12-07  9:30     ` Mel Gorman
2009-12-16 12:14     ` Wu Fengguang
2009-12-16 12:14       ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207053806.GA17052@elte.hu \
    --to=mingo@elte.hu \
    --cc=achiang@hp.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=cl@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=haicheng.li@intel.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mel@csn.ul.ie \
    --cc=randy.dunlap@oracle.com \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.