From: Pete Zaitcev <zaitcev@redhat.com>
To: Colin McCabe <cmccabe@alumni.cmu.edu>
Cc: Project Hail List <hail-devel@vger.kernel.org>,
Jeff Garzik <jeff@garzik.org>,
Colin McCabe <cmccabe@cobalt.club.cc.cmu.edu>,
Colin McCabe <cmccabe@alumni.cmu.edu>
Subject: Re: [PATCH 4/6] cld: modify server code to use logging macros
Date: Tue, 8 Dec 2009 11:13:39 -0700 [thread overview]
Message-ID: <20091208111339.5c12115d@redhat.com> (raw)
In-Reply-To: <1260232984-26726-5-git-send-email-cmccabe@alumni.cmu.edu>
On Mon, 7 Dec 2009 16:43:02 -0800
Colin McCabe <cmccabe@alumni.cmu.edu> wrote:
> +++ b/server/cld.h
> @@ -26,6 +26,7 @@
> #include <glib.h>
> #include "cldb.h"
> #include <cld_msg.h>
> +#include "common.h"
> #include <libtimer.h>
This should be <common.h> since it's common (in include).
> -extern int debugging;
> +extern struct cld_log srv_log;
> - applog(LOG_INFO, "databases down");
> + CLD_INFO(&srv_log, "databases down");
Great, you took code that was common across Hail and made it specific
to CLD again.
-- Pete
next prev parent reply other threads:[~2009-12-08 18:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-08 0:42 [PATCH 0/6] logging refactoring Colin McCabe
2009-12-08 0:42 ` [PATCH 1/6] cld: Declare common.c functions in common.h Colin McCabe
2009-12-08 0:43 ` [PATCH 2/6] cld: create logging macros Colin McCabe
2009-12-08 0:43 ` [PATCH 3/6] cld: modify client code to use " Colin McCabe
2009-12-08 0:43 ` [PATCH 4/6] cld: modify server " Colin McCabe
2009-12-08 0:43 ` [PATCH 5/6] cld: modify cld-dns " Colin McCabe
2009-12-08 0:43 ` [PATCH 6/6] cld: Tweak some log levels in cldc dns Colin McCabe
2009-12-08 18:13 ` Pete Zaitcev [this message]
2009-12-08 19:08 ` [PATCH 4/6] cld: modify server code to use logging macros Colin McCabe
2009-12-08 21:28 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2009-12-09 0:11 [PATCH 0/6 v2] logging refactoring Colin McCabe
2009-12-09 0:11 ` [PATCH 4/6] cld: modify server code to use logging macros Colin McCabe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091208111339.5c12115d@redhat.com \
--to=zaitcev@redhat.com \
--cc=cmccabe@alumni.cmu.edu \
--cc=cmccabe@cobalt.club.cc.cmu.edu \
--cc=hail-devel@vger.kernel.org \
--cc=jeff@garzik.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.