[PATCH 7/7] ASoC: S3C24XX: Remove I2Sv3 specific check

[PATCH 7/7] ASoC: S3C24XX: Remove I2Sv3 specific check

[jassisinghbrar]

From: Jassi Brar <jassi.brar@samsung.com>

Since, now the I2Sv3 driver itself figures out and provides the start
address of the base register, the s3c64xx specific patch can be
discarded in the I2Sv2 core code.

Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
 sound/soc/s3c24xx/s3c-i2s-v2.c |   18 ------------------
 1 files changed, 0 insertions(+), 18 deletions(-)

diff --git a/sound/soc/s3c24xx/s3c-i2s-v2.c b/sound/soc/s3c24xx/s3c-i2s-v2.c
index e994d83..422b74c 100644
--- a/sound/soc/s3c24xx/s3c-i2s-v2.c
+++ b/sound/soc/s3c24xx/s3c-i2s-v2.c
@@ -628,24 +628,6 @@ int s3c_i2sv2_probe(struct platform_device *pdev,
 	/* record our i2s structure for later use in the callbacks */
 	dai->private_data = i2s;
 
-	if (!base) {
-		struct resource *res = platform_get_resource(pdev,
-							     IORESOURCE_MEM,
-							     0);
-		if (!res) {
-			dev_err(dev, "Unable to get register resource\n");
-			return -ENXIO;
-		}
-
-		if (!request_mem_region(res->start, resource_size(res),
-					"s3c64xx-i2s-v4")) {
-			dev_err(dev, "Unable to request register region\n");
-			return -EBUSY;
-		}
-
-		base = res->start;
-	}
-
 	i2s->regs = ioremap(base, 0x100);
 	if (i2s->regs == NULL) {
 		dev_err(dev, "cannot ioremap registers\n");
-- 
1.6.2.5

Re: [PATCH 7/7] ASoC: S3C24XX: Remove I2Sv3 specific check

[Mark Brown]

On Wed, Dec 09, 2009 at 01:30:01PM +0900, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>

> Since, now the I2Sv3 driver itself figures out and provides the start
> address of the base register, the s3c64xx specific patch can be
> discarded in the I2Sv2 core code.

> -	if (!base) {
> -		struct resource *res = platform_get_resource(pdev,

This is used by the S3C24xx IIS as well so they need converting over
before this can be removed.  To be honest I hadn't realised that S3C64xx
was using this at all.

Re: [PATCH 7/7] ASoC: S3C24XX: Remove I2Sv3 specific check

[jassi brar]

On Wed, Dec 9, 2009 at 7:41 PM, Mark Brown
<broonie@opensource.wolfsonmicro.com> wrote:
> On Wed, Dec 09, 2009 at 01:30:01PM +0900, jassisinghbrar@gmail.com wrote:
>> From: Jassi Brar <jassi.brar@samsung.com>
>
>> Since, now the I2Sv3 driver itself figures out and provides the start
>> address of the base register, the s3c64xx specific patch can be
>> discarded in the I2Sv2 core code.
>
>> -     if (!base) {
>> -             struct resource *res = platform_get_resource(pdev,
>
> This is used by the S3C24xx IIS as well so they need converting over
> before this can be removed.  To be honest I hadn't realised that S3C64xx
> was using this at all.
Well, only s3c64xx was using this piece of code. s3c2412-i2s.c always passed
physical address of I2S base. And there is no other user of this function.
So, i think we can safely remove it.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH 7/7] ASoC: S3C24XX: Remove I2Sv3 specific check

[Mark Brown]

On Wed, Dec 09, 2009 at 07:48:58PM +0900, jassi brar wrote:
> On Wed, Dec 9, 2009 at 7:41 PM, Mark Brown

> > This is used by the S3C24xx IIS as well so they need converting over
> > before this can be removed.  To be honest I hadn't realised that S3C64xx
> > was using this at all.

> Well, only s3c64xx was using this piece of code. s3c2412-i2s.c always passed
> physical address of I2S base. And there is no other user of this function.
> So, i think we can safely remove it.

Yes, it's the other way round to that I remembered.