[PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()

[PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()

[Eli Cohen]

If mlx4_init_port_info() fails, cleanup the initialized ports only.

Signed-off-by: Eli Cohen <eli-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
---
 drivers/net/mlx4/main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/main.c b/drivers/net/mlx4/main.c
index 6f5a3cf..0c868c9 100644
--- a/drivers/net/mlx4/main.c
+++ b/drivers/net/mlx4/main.c
@@ -1294,7 +1294,7 @@ static int __mlx4_init_one(struct pci_dev *pdev, const struct pci_device_id *id)
 	return 0;
 
 err_port:
-	for (port = 1; port <= dev->caps.num_ports; port++)
+	for (--port; port >= 1; --port)
 		mlx4_cleanup_port_info(&priv->port[port]);
 
 	mlx4_cleanup_counters_table(dev);
-- 
1.6.5.5

Re: [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()

[Roland Dreier]

Looks like a valid fix but your patch doesn't apply.  I don't seem to
have mlx4_cleanup_counters_table() in my tree.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Re: [PATCH] mlx4_core: Cleanup bug in __mlx4_init_one()

[Eli Cohen]

On Wed, Dec 09, 2009 at 02:35:18PM -0800, Roland Dreier wrote:
> Looks like a valid fix but your patch doesn't apply.  I don't seem to
> have mlx4_cleanup_counters_table() in my tree.

I noticed that already. I'll send a new patch in my next working day.