From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Jari Aalto <jari.aalto@cante.net>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] tag -d: print sha1 of deleted tag
Date: Thu, 10 Dec 2009 08:36:46 -0500 [thread overview]
Message-ID: <20091210133645.GA2149@coredump.intra.peff.net> (raw)
In-Reply-To: <4B20F733.6010401@drmicha.warpmail.net>
On Thu, Dec 10, 2009 at 02:27:15PM +0100, Michael J Gruber wrote:
> > 1. It is not immediately obvious to a user seeing this message
> > for this first time exactly what the trailing sha1 means. We
> > already had this discussion with "git branch -d" and decided
> > that "(was DEADBEEF)" was more readable.
>
> So, should we simply go with that then?
I think so. Jari obviously disagrees, but I don't have much more to say
in favor of it except that I find the other ugly and unintuitive. So it
is up to you what you want to submit and Junio what he wants to apply.
:)
> Meanwhile, RFCs/PATCHes crossed paths. I take it that Zoltan suggests
> giving the same output for force-overwritten existing tags. I beat him
> by 11 minutes, though ;)
Yes, I think if you are going to protect "tag -d", you might as well
protect overwriting, as well. Which made me think at first that we need
something similar for "branch -f", but I don't think we do; the last
branch value will be left in the reflog (but with tags, there is no
reflog).
-Peff
next prev parent reply other threads:[~2009-12-10 13:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 10:06 FEATURE REQUEST: display <commit SHA> in message: git tag -d Jari Aalto
2009-12-10 12:23 ` [PATCH] tag -d: print sha1 of deleted tag Michael J Gruber
2009-12-10 12:47 ` Björn Steinbrink
2009-12-10 13:21 ` Michael J Gruber
2009-12-10 12:49 ` Jeff King
2009-12-10 13:16 ` Jari Aalto
2009-12-10 13:27 ` Michael J Gruber
2009-12-10 13:36 ` Jeff King [this message]
2009-12-10 14:01 ` [PATCH v2] " Michael J Gruber
2009-12-10 14:16 ` Zoltán Füzesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091210133645.GA2149@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jari.aalto@cante.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.