From: Jari Aalto <jari.aalto@cante.net>
To: Jeff King <peff@peff.net>
Cc: Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] tag -d: print sha1 of deleted tag
Date: Thu, 10 Dec 2009 15:16:07 +0200 [thread overview]
Message-ID: <87hbrz6kbs.fsf@jondo.cante.net> (raw)
In-Reply-To: <20091210124929.GA444@coredump.intra.peff.net> (Jeff King's message of "Thu, 10 Dec 2009 07:49:29 -0500")
Jeff King <peff@peff.net> writes:
> On Thu, Dec 10, 2009 at 01:23:43PM +0100, Michael J Gruber wrote:
>
>> Print the sha1 of the deleted tag (in addition to the tag name) so that
>> one can easily recreate a mistakenly deleted tag:
>>
>> git tag -d tagname
>> Deleted tag 'tagname' DEADBEEF
>> git tag 'tagname' DEADBEEF # for lightweight tags
>> git update-ref refs/tags/'tagname' DEADBEEF # for annotated tags
> That being said, I am not a fan of the cut-and-paste format. This is not
> something that happens so frequently
It dpends on user. For me it it does.
> 1. It is not immediately obvious to a user seeing this message
> for this first time exactly what the trailing sha1 means.
>
> 2. Even if they know what it means, it is not immediately obvious that
> the error line is meant to be cut-and-pasted.
"not meant" specifically, but it's very convenient to have it in format
that happens to be "cut-n-paste ready". The SHA itself is easily
understood in the context.
Thanks for all that have so quickly implemented this,
Jari
next prev parent reply other threads:[~2009-12-10 13:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 10:06 FEATURE REQUEST: display <commit SHA> in message: git tag -d Jari Aalto
2009-12-10 12:23 ` [PATCH] tag -d: print sha1 of deleted tag Michael J Gruber
2009-12-10 12:47 ` Björn Steinbrink
2009-12-10 13:21 ` Michael J Gruber
2009-12-10 12:49 ` Jeff King
2009-12-10 13:16 ` Jari Aalto [this message]
2009-12-10 13:27 ` Michael J Gruber
2009-12-10 13:36 ` Jeff King
2009-12-10 14:01 ` [PATCH v2] " Michael J Gruber
2009-12-10 14:16 ` Zoltán Füzesi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbrz6kbs.fsf@jondo.cante.net \
--to=jari.aalto@cante.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.