[PATCH dmraid 0/1] pdc metadata bug fix

[PATCH dmraid 0/1] pdc metadata bug fix

[NeilBrown]

Hi,
 the follow patch fixes a bug with pdc metadata handling, as described
 in that patch.

 I noted on reading the code that if pdc_read_metadata finds the metadata
 at and address listed in begin_sectors, info->u32 is set to an offset
 from the start of the device, rather than from the end, and then the use
 of info->u32 in setup_rd becomes incorrect.
 I didn't try to fix this as I don't know all the implications of
 a 'begin_sectors' address being used.

Thanks,
NeilBrown

[PATCH dmraid 1/1] Ensure metadata dump of pdc metadata has the correct offset.

[NeilBrown]

[-- Attachment #1: pdc-metadata-dump-fix --]
[-- Type: text/plain, Size: 717 bytes --]

a read_metadata function needds to set *offset so that file_metadata
can create the correct xxx/dev-offset file.
pdf_read_metadata does not set *offset.

This patch add the appropriate setting.

Signed-off-by: NeilBrown <neilb@suse.de>
---
 1.0.0.rc16/lib/format/ataraid/pdc.c |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

--- dmraid.orig/1.0.0.rc16/lib/format/ataraid/pdc.c
+++ dmraid/1.0.0.rc16/lib/format/ataraid/pdc.c
@@ -202,8 +202,11 @@ pdc_read_metadata(struct lib_context *lc
 							break;
 
 					/* Memorize main metadata sector. */
-					} else if (!info->u32)
+					} else if (!info->u32) {
 						info->u32 = *s;
+						*offset = sub ? di->sectors - *s : *s;
+					}
+
 				}
 			}
 		}

Re: [PATCH dmraid 1/1] Ensure metadata dump of pdc metadata has the correct offset.

[Heinz Mauelshagen]

Applied to the sources repository.

Thanks,
Heinz

On Fri, 2009-12-11 at 14:27 +1100, NeilBrown wrote:
> plain text document attachment (pdc-metadata-dump-fix)
> a read_metadata function needds to set *offset so that file_metadata
> can create the correct xxx/dev-offset file.
> pdf_read_metadata does not set *offset.
> 
> This patch add the appropriate setting.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>  1.0.0.rc16/lib/format/ataraid/pdc.c |    5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> --- dmraid.orig/1.0.0.rc16/lib/format/ataraid/pdc.c
> +++ dmraid/1.0.0.rc16/lib/format/ataraid/pdc.c
> @@ -202,8 +202,11 @@ pdc_read_metadata(struct lib_context *lc
>  							break;
>  
>  					/* Memorize main metadata sector. */
> -					} else if (!info->u32)
> +					} else if (!info->u32) {
>  						info->u32 = *s;
> +						*offset = sub ? di->sectors - *s : *s;
> +					}
> +
>  				}
>  			}
>  		}
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel