All of lore.kernel.org
 help / color / mirror / Atom feed
From: Frederic Weisbecker <fweisbec@gmail.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
	Wenji Huang <wenji.huang@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING
Date: Fri, 11 Dec 2009 13:07:55 +0100	[thread overview]
Message-ID: <20091211120753.GE5244@nowhere> (raw)
In-Reply-To: <4B2217EA.4010902@cn.fujitsu.com>

On Fri, Dec 11, 2009 at 05:59:06PM +0800, Li Zefan wrote:
> MATCH_FULL matching for PTR_STRING is not working correctly:
> 
>   # echo 'func == vt' > events/bkl/lock_kernel/filter
>   # echo 1 > events/bkl/lock_kernel/enable
>   ...
>   # cat trace
>    Xorg-1484  [000]  1973.392586: lock_kernel: ... func=vt_ioctl()
>     gpm-1402  [001]  1974.027740: lock_kernel: ... func=vt_ioctl()
> 
> We should pass to regex.match(..., len) the length (including '\0')
> of the source string instead of the length of the pattern string.
> 
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>


This patch is cool but it seems to also break middle and end
matching (at least what was working with end matching :)

I know you fix that in the subsequent patches, but please
avoid that. A fix should not bring another known bug,
event if it's fixed in the same batch.

Thanks.


  reply	other threads:[~2009-12-11 12:07 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  9:58 [PATCH 1/4] ftrace: Fix MATCH_END_ONLY filter matching Li Zefan
2009-12-11  9:59 ` [PATCH 2/4] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING Li Zefan
2009-12-11 12:07   ` Frederic Weisbecker [this message]
2009-12-14  1:40     ` Li Zefan
2009-12-14 12:21       ` Frederic Weisbecker
2009-12-14 12:23       ` Frederic Weisbecker
2009-12-11  9:59 ` [PATCH 3/4] tracing/filters: Fix MATCH_FRONT_ONLY filter matching Li Zefan
2009-12-11 12:02   ` Frederic Weisbecker
2009-12-14  1:43     ` Li Zefan
2009-12-14 12:22       ` Frederic Weisbecker
2009-12-11  9:59 ` [PATCH 4/4] tracing/filters: Fix MATCH_EBD_ONLY " Li Zefan
2009-12-11 15:14   ` Steven Rostedt
2009-12-14  1:08     ` Li Zefan
2009-12-11 12:10 ` [PATCH 1/4] ftrace: Fix MATCH_END_ONLY " Frederic Weisbecker
2009-12-11 12:20 ` Frederic Riss
2009-12-11 12:27   ` Frederic Weisbecker
2009-12-11 15:10     ` Steven Rostedt
2009-12-11 17:46       ` Frederic Weisbecker
2009-12-14  1:04         ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091211120753.GE5244@nowhere \
    --to=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=wenji.huang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.