All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Wenji Huang <wenji.huang@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/4] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING
Date: Fri, 11 Dec 2009 17:59:06 +0800	[thread overview]
Message-ID: <4B2217EA.4010902@cn.fujitsu.com> (raw)
In-Reply-To: <4B2217D0.5000308@cn.fujitsu.com>

MATCH_FULL matching for PTR_STRING is not working correctly:

  # echo 'func == vt' > events/bkl/lock_kernel/filter
  # echo 1 > events/bkl/lock_kernel/enable
  ...
  # cat trace
   Xorg-1484  [000]  1973.392586: lock_kernel: ... func=vt_ioctl()
    gpm-1402  [001]  1974.027740: lock_kernel: ... func=vt_ioctl()

We should pass to regex.match(..., len) the length (including '\0')
of the source string instead of the length of the pattern string.

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
---
 kernel/trace/trace_events_filter.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/kernel/trace/trace_events_filter.c b/kernel/trace/trace_events_filter.c
index 50504cb..c8eb1c0 100644
--- a/kernel/trace/trace_events_filter.c
+++ b/kernel/trace/trace_events_filter.c
@@ -211,8 +211,9 @@ static int filter_pred_pchar(struct filter_pred *pred, void *event,
 {
 	char **addr = (char **)(event + pred->offset);
 	int cmp, match;
+	int len = strlen(*addr) + 1;	/* including tailing '\0' */
 
-	cmp = pred->regex.match(*addr, &pred->regex, pred->regex.field_len);
+	cmp = pred->regex.match(*addr, &pred->regex, len);
 
 	match = cmp ^ pred->not;
 
@@ -781,10 +782,8 @@ static int filter_add_pred(struct filter_parse_state *ps,
 			pred->regex.field_len = field->size;
 		} else if (field->filter_type == FILTER_DYN_STRING)
 			fn = filter_pred_strloc;
-		else {
+		else
 			fn = filter_pred_pchar;
-			pred->regex.field_len = strlen(pred->regex.pattern);
-		}
 	} else {
 		if (field->is_signed)
 			ret = strict_strtoll(pred->regex.pattern, 0, &val);
-- 
1.6.3


  reply	other threads:[~2009-12-11  9:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11  9:58 [PATCH 1/4] ftrace: Fix MATCH_END_ONLY filter matching Li Zefan
2009-12-11  9:59 ` Li Zefan [this message]
2009-12-11 12:07   ` [PATCH 2/4] tracing/filters: Fix MATCH_FULL filter matching for PTR_STRING Frederic Weisbecker
2009-12-14  1:40     ` Li Zefan
2009-12-14 12:21       ` Frederic Weisbecker
2009-12-14 12:23       ` Frederic Weisbecker
2009-12-11  9:59 ` [PATCH 3/4] tracing/filters: Fix MATCH_FRONT_ONLY filter matching Li Zefan
2009-12-11 12:02   ` Frederic Weisbecker
2009-12-14  1:43     ` Li Zefan
2009-12-14 12:22       ` Frederic Weisbecker
2009-12-11  9:59 ` [PATCH 4/4] tracing/filters: Fix MATCH_EBD_ONLY " Li Zefan
2009-12-11 15:14   ` Steven Rostedt
2009-12-14  1:08     ` Li Zefan
2009-12-11 12:10 ` [PATCH 1/4] ftrace: Fix MATCH_END_ONLY " Frederic Weisbecker
2009-12-11 12:20 ` Frederic Riss
2009-12-11 12:27   ` Frederic Weisbecker
2009-12-11 15:10     ` Steven Rostedt
2009-12-11 17:46       ` Frederic Weisbecker
2009-12-14  1:04         ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2217EA.4010902@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    --cc=wenji.huang@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.