All of lore.kernel.org
 help / color / mirror / Atom feed
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: tree with htc dream support
Date: Sat, 12 Dec 2009 12:25:36 +0100	[thread overview]
Message-ID: <20091212112536.GA2302@elf.ucw.cz> (raw)
In-Reply-To: <d6200be20912112142r7bdf8f18o31edd4457aa64998@mail.gmail.com>

On Fri 2009-12-11 21:42:07, Arve Hj?nnev?g wrote:
> On Sat, Dec 5, 2009 at 4:38 PM, Brian Swetland <swetland@google.com> wrote:
> > Arve's about to take our common and msm trees and rebase them over the .32,
> > which may be useful for reference -- at least as a snapshot of a fully
> > functional set of patches that android donut and eclair run on, on
> > production hardware.? We'll make that available as soon as we have something
> > that's bootable.
> >
> > Brian
> >
> >
> 
> A first pass of this is available in the android-msm-2.6.32-test1
> branch at git://android.git.kernel.org/kernel/experimental.git.

According to some docs, i2c_detach can be just removed, so...?

Then I got this:

  CC      drivers/input/misc/gpio_axis.o
  CC      drivers/input/misc/keychord.o
drivers/input/misc/keychord.c: In function 'keychord_event':
drivers/input/misc/keychord.c:129: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this
function)drivers/input/misc/keychord.c:129: error: (Each undeclared
identifier is reported only once
drivers/input/misc/keychord.c:129: error: for each function it appears
in.)
drivers/input/misc/keychord.c: In function 'keychord_read':
drivers/input/misc/keychord.c:205: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this
function)drivers/input/misc/keychord.c:205: error: implicit
declaration of function 'signal_pending'
drivers/input/misc/keychord.c:205: error: implicit declaration of
function 'schedule'
make[3]: *** [drivers/input/misc/keychord.o] Error 1
make[2]: *** [drivers/input/misc] Error 2
make[1]: *** [drivers/input] Error 2
make: *** [drivers] Error 2
12.60user 2.53system 16.93 (0m16.939s) elapsed 89.36%CPU
pavel at amd:/data/l/linux-msm-32$

I used this to fix the compilation...

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/drivers/i2c/chips/mt9t013.c b/drivers/i2c/chips/mt9t013.c
index e911ece..200a9f8 100755
--- a/drivers/i2c/chips/mt9t013.c
+++ b/drivers/i2c/chips/mt9t013.c
@@ -1298,7 +1298,6 @@ static int mt9t013_remove(struct i2c_client *client)
 	struct mt9t013_data *mt = i2c_get_clientdata(client);
 	free_irq(client->irq, mt);
 	deinit_suspend();
-	i2c_detach_client(client);
 	pclient = NULL;
 	misc_deregister(&mt9t013_device);
 	kfree(mt);
diff --git a/drivers/input/misc/keychord.c b/drivers/input/misc/keychord.c
index ea94f26..ca23905 100644
--- a/drivers/input/misc/keychord.c
+++ b/drivers/input/misc/keychord.c
@@ -23,6 +23,7 @@
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
 #include <linux/keychord.h>
+#include <linux/sched.h>
 
 #define KEYCHORD_NAME		"keychord"
 #define BUFFER_SIZE			16

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Arve Hj?nnev?g <arve@android.com>
Cc: Brian Swetland <swetland@google.com>,
	Daniel Walker <dwalker@codeaurora.org>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Iliyan Malchev <malchev@google.com>,
	linux-kernel@codeaurora.org
Subject: Re: tree with htc dream support
Date: Sat, 12 Dec 2009 12:25:36 +0100	[thread overview]
Message-ID: <20091212112536.GA2302@elf.ucw.cz> (raw)
In-Reply-To: <d6200be20912112142r7bdf8f18o31edd4457aa64998@mail.gmail.com>

On Fri 2009-12-11 21:42:07, Arve Hj?nnev?g wrote:
> On Sat, Dec 5, 2009 at 4:38 PM, Brian Swetland <swetland@google.com> wrote:
> > Arve's about to take our common and msm trees and rebase them over the .32,
> > which may be useful for reference -- at least as a snapshot of a fully
> > functional set of patches that android donut and eclair run on, on
> > production hardware.  We'll make that available as soon as we have something
> > that's bootable.
> >
> > Brian
> >
> >
> 
> A first pass of this is available in the android-msm-2.6.32-test1
> branch at git://android.git.kernel.org/kernel/experimental.git.

According to some docs, i2c_detach can be just removed, so...?

Then I got this:

  CC      drivers/input/misc/gpio_axis.o
  CC      drivers/input/misc/keychord.o
drivers/input/misc/keychord.c: In function 'keychord_event':
drivers/input/misc/keychord.c:129: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this
function)drivers/input/misc/keychord.c:129: error: (Each undeclared
identifier is reported only once
drivers/input/misc/keychord.c:129: error: for each function it appears
in.)
drivers/input/misc/keychord.c: In function 'keychord_read':
drivers/input/misc/keychord.c:205: error: 'TASK_INTERRUPTIBLE'
undeclared (first use in this
function)drivers/input/misc/keychord.c:205: error: implicit
declaration of function 'signal_pending'
drivers/input/misc/keychord.c:205: error: implicit declaration of
function 'schedule'
make[3]: *** [drivers/input/misc/keychord.o] Error 1
make[2]: *** [drivers/input/misc] Error 2
make[1]: *** [drivers/input] Error 2
make: *** [drivers] Error 2
12.60user 2.53system 16.93 (0m16.939s) elapsed 89.36%CPU
pavel@amd:/data/l/linux-msm-32$

I used this to fix the compilation...

Signed-off-by: Pavel Machek <pavel@ucw.cz>

diff --git a/drivers/i2c/chips/mt9t013.c b/drivers/i2c/chips/mt9t013.c
index e911ece..200a9f8 100755
--- a/drivers/i2c/chips/mt9t013.c
+++ b/drivers/i2c/chips/mt9t013.c
@@ -1298,7 +1298,6 @@ static int mt9t013_remove(struct i2c_client *client)
 	struct mt9t013_data *mt = i2c_get_clientdata(client);
 	free_irq(client->irq, mt);
 	deinit_suspend();
-	i2c_detach_client(client);
 	pclient = NULL;
 	misc_deregister(&mt9t013_device);
 	kfree(mt);
diff --git a/drivers/input/misc/keychord.c b/drivers/input/misc/keychord.c
index ea94f26..ca23905 100644
--- a/drivers/input/misc/keychord.c
+++ b/drivers/input/misc/keychord.c
@@ -23,6 +23,7 @@
 #include <linux/fs.h>
 #include <linux/miscdevice.h>
 #include <linux/keychord.h>
+#include <linux/sched.h>
 
 #define KEYCHORD_NAME		"keychord"
 #define BUFFER_SIZE			16

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2009-12-12 11:25 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-05 22:11 tree with htc dream support Pavel Machek
2009-12-05 22:11 ` Pavel Machek
2009-12-05 23:12 ` Daniel Walker
2009-12-05 23:12   ` Daniel Walker
2009-12-06  0:38   ` Brian Swetland
2009-12-06  7:43     ` Pavel Machek
2009-12-06  7:43       ` Pavel Machek
2009-12-06 13:55     ` Daniel Walker
2009-12-06 13:55       ` Daniel Walker
2009-12-12  5:42     ` Arve Hjønnevåg
2009-12-12  5:42       ` Arve Hjønnevåg
2009-12-12 11:17       ` Pavel Machek
2009-12-12 11:17         ` Pavel Machek
2009-12-12 11:25       ` Pavel Machek [this message]
2009-12-12 11:25         ` Pavel Machek
2009-12-12 11:51         ` Arve Hjønnevåg
2009-12-12 11:51           ` Arve Hjønnevåg
2009-12-12 12:11           ` Arve Hjønnevåg
2009-12-12 12:11             ` Arve Hjønnevåg
2009-12-12 17:53         ` Pavel Machek
2009-12-12 17:53           ` Pavel Machek
2009-12-12 22:41           ` Arve Hjønnevåg
2009-12-12 22:41             ` Arve Hjønnevåg
2009-12-15  6:30             ` Arve Hjønnevåg
2009-12-15  6:30               ` Arve Hjønnevåg
2009-12-12 14:18       ` Daniel Walker
2009-12-12 14:18         ` Daniel Walker
2009-12-12 22:34         ` Arve Hjønnevåg
2009-12-12 22:34           ` Arve Hjønnevåg
2009-12-13 21:25           ` Pavel Machek
2009-12-13 21:25             ` Pavel Machek
2009-12-15  6:34             ` Arve Hjønnevåg
2009-12-15  6:34               ` Arve Hjønnevåg
2009-12-15 22:20               ` Pavel Machek
2009-12-15 22:20                 ` Pavel Machek
2009-12-27  9:35               ` Pavel Machek
2009-12-27  9:35                 ` Pavel Machek
2009-12-27 20:15                 ` Pavel Machek
2009-12-27 20:15                   ` Pavel Machek
2009-12-27 20:20                   ` Brian Swetland
2009-12-27 20:20                     ` Brian Swetland
2009-12-27 20:37                     ` Pavel Machek
2009-12-27 20:37                       ` Pavel Machek
2009-12-27 21:13                       ` Pavel Machek
2009-12-27 21:13                         ` Pavel Machek
2009-12-27 21:53                         ` Pavel Machek
2009-12-27 21:53                           ` Pavel Machek
2009-12-28  0:46                         ` Brian Swetland
2009-12-28  0:46                           ` Brian Swetland
2009-12-27 10:18                           ` Pavel Machek
2009-12-27 10:18                             ` Pavel Machek
2009-12-28 20:24                             ` Brian Swetland
2009-12-28 20:24                               ` Brian Swetland
2009-12-28 20:48                               ` Pavel Machek
2009-12-28 20:48                                 ` Pavel Machek
2009-12-28 20:52                                 ` Pavel Machek
2009-12-28 20:52                                   ` Pavel Machek
2009-12-28 21:08                                 ` Brian Swetland
2009-12-28 21:08                                   ` Brian Swetland
2010-01-01 14:54                                   ` Pavel Machek
2010-01-01 14:54                                     ` Pavel Machek
2009-12-29  1:25                                 ` Daniel Walker
2009-12-29  1:25                                   ` Daniel Walker
2010-01-01 15:18                                   ` Pavel Machek
2010-01-01 15:18                                     ` Pavel Machek
2010-01-01 16:08                                     ` Daniel Walker
2010-01-01 16:08                                       ` Daniel Walker
2010-01-02 10:55                                       ` Pavel Machek
2010-01-02 10:55                                         ` Pavel Machek
2010-01-05 21:31                                         ` Daniel Walker
2010-01-05 21:31                                           ` Daniel Walker
2009-12-06  7:41   ` Pavel Machek
2009-12-06  7:41     ` Pavel Machek
2009-12-06 13:51     ` Daniel Walker
2009-12-06 13:51       ` Daniel Walker
2009-12-08  8:53       ` Pavel Machek
2009-12-08  8:53         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091212112536.GA2302@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.