* [PATCH] rtl8180: Remove usage of deprecated 'qual'
@ 2009-12-13 0:04 Larry Finger
2009-12-13 1:22 ` John W. Linville
0 siblings, 1 reply; 3+ messages in thread
From: Larry Finger @ 2009-12-13 0:04 UTC (permalink / raw)
To: John W Linville; +Cc: linux-wireless
When building rtl8180, the following warning occurs:
CC [M] drivers/net/wireless/rtl818x/rtl8180_dev.o
drivers/net/wireless/rtl818x/rtl8180_dev.c: In function ‘rtl8180_handle_rx’:
drivers/net/wireless/rtl818x/rtl8180_dev.c:135: warning: ‘qual’ is deprecated
(declared at include/net/mac80211.h:562)
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
---
John,
This patch has very low priority.
Larry
---
Index: wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtl818x/rtl8180_dev.c
+++ wireless-testing/drivers/net/wireless/rtl818x/rtl8180_dev.c
@@ -132,7 +132,6 @@ static void rtl8180_handle_rx(struct iee
rx_status.antenna = (flags2 >> 15) & 1;
/* TODO: improve signal/rssi reporting */
- rx_status.qual = flags2 & 0xFF;
rx_status.signal = (flags2 >> 8) & 0x7F;
/* XXX: is this correct? */
rx_status.rate_idx = (flags >> 20) & 0xF;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] rtl8180: Remove usage of deprecated 'qual'
2009-12-13 0:04 [PATCH] rtl8180: Remove usage of deprecated 'qual' Larry Finger
@ 2009-12-13 1:22 ` John W. Linville
2009-12-13 13:10 ` Johannes Berg
0 siblings, 1 reply; 3+ messages in thread
From: John W. Linville @ 2009-12-13 1:22 UTC (permalink / raw)
To: Larry Finger; +Cc: linux-wireless
On Sat, Dec 12, 2009 at 06:04:46PM -0600, Larry Finger wrote:
> When building rtl8180, the following warning occurs:
>
> CC [M] drivers/net/wireless/rtl818x/rtl8180_dev.o
> drivers/net/wireless/rtl818x/rtl8180_dev.c: In function ‘rtl8180_handle_rx’:
> drivers/net/wireless/rtl818x/rtl8180_dev.c:135: warning: ‘qual’ is deprecated
> (declared at include/net/mac80211.h:562)
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
FWIW, I think Johannes has a hunk like this in his patch to finally
remove qual.
John
--
John W. Linville Someday the world will need a hero, and you
linville@tuxdriver.com might be all we have. Be ready.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rtl8180: Remove usage of deprecated 'qual'
2009-12-13 1:22 ` John W. Linville
@ 2009-12-13 13:10 ` Johannes Berg
0 siblings, 0 replies; 3+ messages in thread
From: Johannes Berg @ 2009-12-13 13:10 UTC (permalink / raw)
To: John W. Linville; +Cc: Larry Finger, linux-wireless
[-- Attachment #1: Type: text/plain, Size: 726 bytes --]
On Sat, 2009-12-12 at 20:22 -0500, John W. Linville wrote:
> On Sat, Dec 12, 2009 at 06:04:46PM -0600, Larry Finger wrote:
> > When building rtl8180, the following warning occurs:
> >
> > CC [M] drivers/net/wireless/rtl818x/rtl8180_dev.o
> > drivers/net/wireless/rtl818x/rtl8180_dev.c: In function ‘rtl8180_handle_rx’:
> > drivers/net/wireless/rtl818x/rtl8180_dev.c:135: warning: ‘qual’ is deprecated
> > (declared at include/net/mac80211.h:562)
> >
> > Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>
> FWIW, I think Johannes has a hunk like this in his patch to finally
> remove qual.
I do, but feel free to take Larry's patch first and then ignore the hunk
in mine.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-13 13:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-13 0:04 [PATCH] rtl8180: Remove usage of deprecated 'qual' Larry Finger
2009-12-13 1:22 ` John W. Linville
2009-12-13 13:10 ` Johannes Berg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.