All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property
Date: Mon, 14 Dec 2009 11:42:55 +0200	[thread overview]
Message-ID: <20091214094255.GA32140@redhat.com> (raw)
In-Reply-To: <4B260846.9020503@redhat.com>

On Mon, Dec 14, 2009 at 10:41:26AM +0100, Gerd Hoffmann wrote:
> On 12/13/09 21:43, Michael S. Tsirkin wrote:
>> Add features property to virtio. This makes it
>> possible to e.g. define machine without indirect
>> buffer support, which is required for 0.10
>> compatibility. or without hardware checksum
>> support, which is required for 0.11 compatibility.
>
> I'd suggest to add flags for the individual features to the drivers  
> which actually use it instead, so you'll have
>
>   -device virtio-net-pci,hw-checksum=0
>
> and
>
>   -device virtio-blk-pci,indirect-buffers=0
>
> cheers,
>   Gerd

Hmm. I hoped to avoid it, there are lots of features so it's a lot of
work and in practice, this will most likely be set by machine
description ...

-- 
MST

  reply	other threads:[~2009-12-14  9:45 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-13 20:43 [Qemu-devel] [PATCH RFC] virtio: add features qdev property Michael S. Tsirkin
2009-12-14  9:41 ` [Qemu-devel] " Gerd Hoffmann
2009-12-14  9:42   ` Michael S. Tsirkin [this message]
2009-12-14 10:24     ` Gerd Hoffmann
2009-12-14 11:10       ` Michael S. Tsirkin
2009-12-14 11:37         ` Gerd Hoffmann
2009-12-14 13:15           ` Michael S. Tsirkin
2009-12-14 13:30           ` Markus Armbruster
2009-12-14 13:59             ` Michael S. Tsirkin
2009-12-14 15:01               ` Gerd Hoffmann
2009-12-14 16:23                 ` Michael S. Tsirkin
2009-12-14 17:18                   ` Gerd Hoffmann
2009-12-14 19:17                     ` Michael S. Tsirkin
2009-12-14 20:40                       ` Gerd Hoffmann
2009-12-14 20:43                         ` Michael S. Tsirkin
2009-12-14 21:12                           ` Gerd Hoffmann
2009-12-14 21:14                             ` Michael S. Tsirkin
2009-12-14 21:24                               ` Gerd Hoffmann
2009-12-14 14:56             ` Gerd Hoffmann
2009-12-14 19:20           ` Michael S. Tsirkin
2009-12-14 20:42             ` Gerd Hoffmann
2009-12-14 11:50         ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091214094255.GA32140@redhat.com \
    --to=mst@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.