From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH RFC] virtio: add features qdev property
Date: Mon, 14 Dec 2009 15:56:38 +0100 [thread overview]
Message-ID: <4B265226.8020700@redhat.com> (raw)
In-Reply-To: <m3y6l51y50.fsf@crossbow.pond.sub.org>
On 12/14/09 14:30, Markus Armbruster wrote:
>> Then the property parser would accepts strings such as 'bit1|bit2' and
>> you can have
>>
>> -device 'virtio-blk-pci,disable=blk-identify|ring-indirect'
>>
>> The driver will just do 'vdev->host_features&= ~disable'.
>
> Use of '|' in option argument syntax is user-hostile, because it
> requires quoting in the shell. What about '+'?
I don't care that much. I've picked '|' because it is 'or' in many
programming languanges and thus sort of intuitive (at least to me).
Using '+' is fine with me too.
cheers,
Gerd
next prev parent reply other threads:[~2009-12-14 14:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-13 20:43 [Qemu-devel] [PATCH RFC] virtio: add features qdev property Michael S. Tsirkin
2009-12-14 9:41 ` [Qemu-devel] " Gerd Hoffmann
2009-12-14 9:42 ` Michael S. Tsirkin
2009-12-14 10:24 ` Gerd Hoffmann
2009-12-14 11:10 ` Michael S. Tsirkin
2009-12-14 11:37 ` Gerd Hoffmann
2009-12-14 13:15 ` Michael S. Tsirkin
2009-12-14 13:30 ` Markus Armbruster
2009-12-14 13:59 ` Michael S. Tsirkin
2009-12-14 15:01 ` Gerd Hoffmann
2009-12-14 16:23 ` Michael S. Tsirkin
2009-12-14 17:18 ` Gerd Hoffmann
2009-12-14 19:17 ` Michael S. Tsirkin
2009-12-14 20:40 ` Gerd Hoffmann
2009-12-14 20:43 ` Michael S. Tsirkin
2009-12-14 21:12 ` Gerd Hoffmann
2009-12-14 21:14 ` Michael S. Tsirkin
2009-12-14 21:24 ` Gerd Hoffmann
2009-12-14 14:56 ` Gerd Hoffmann [this message]
2009-12-14 19:20 ` Michael S. Tsirkin
2009-12-14 20:42 ` Gerd Hoffmann
2009-12-14 11:50 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B265226.8020700@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.