All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel@caiaq.de (Daniel Mack)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: MX3: make CPU revision number detection work on all boards
Date: Tue, 15 Dec 2009 08:02:36 +0800	[thread overview]
Message-ID: <20091215000236.GI28375@buzzloop.caiaq.de> (raw)
In-Reply-To: <1260833262-18507-1-git-send-email-wd@denx.de>

On Tue, Dec 15, 2009 at 12:27:42AM +0100, Wolfgang Denk wrote:
> Commit 52939c03 (ARM: MX3: fix CPU revision number detection) started
> using the CPU's SREV register for revision number detection. This
> makes it mandatory to have a valid SPBA0 mapping. Add this to the
> global map_io code instead of adding multiple copies for each board.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Daniel Mack <daniel@caiaq.de>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>

Ah, that explains it of course. Sorry I didn't see that.

Daniel


> Tested on Qong (EVB-Lite)
> Tested-by: Wolfgang Denk <wd@denx.de>
> ---
>  arch/arm/mach-mx3/mm.c       |    5 +++++
>  arch/arm/mach-mx3/mx31ads.c  |    5 -----
>  arch/arm/mach-mx3/mx31lite.c |    5 -----
>  arch/arm/mach-mx3/mx31pdk.c  |    5 -----
>  4 files changed, 5 insertions(+), 15 deletions(-)
> 
> diff --git a/arch/arm/mach-mx3/mm.c b/arch/arm/mach-mx3/mm.c
> index bedf5b8..6858a4f 100644
> --- a/arch/arm/mach-mx3/mm.c
> +++ b/arch/arm/mach-mx3/mm.c
> @@ -65,6 +65,11 @@ static struct map_desc mxc_io_desc[] __initdata = {
>  		.pfn		= __phys_to_pfn(AIPS2_BASE_ADDR),
>  		.length		= AIPS2_SIZE,
>  		.type		= MT_DEVICE_NONSHARED
> +	}, {
> +		.virtual = SPBA0_BASE_ADDR_VIRT,
> +		.pfn = __phys_to_pfn(SPBA0_BASE_ADDR),
> +		.length = SPBA0_SIZE,
> +		.type = MT_DEVICE_NONSHARED
>  	},
>  };
>  
> diff --git a/arch/arm/mach-mx3/mx31ads.c b/arch/arm/mach-mx3/mx31ads.c
> index 0497c15..3e7bafa 100644
> --- a/arch/arm/mach-mx3/mx31ads.c
> +++ b/arch/arm/mach-mx3/mx31ads.c
> @@ -494,11 +494,6 @@ static void mxc_init_i2c(void)
>   */
>  static struct map_desc mx31ads_io_desc[] __initdata = {
>  	{
> -		.virtual	= SPBA0_BASE_ADDR_VIRT,
> -		.pfn		= __phys_to_pfn(SPBA0_BASE_ADDR),
> -		.length		= SPBA0_SIZE,
> -		.type		= MT_DEVICE_NONSHARED
> -	}, {
>  		.virtual	= CS4_BASE_ADDR_VIRT,
>  		.pfn		= __phys_to_pfn(CS4_BASE_ADDR),
>  		.length		= CS4_SIZE / 2,
> diff --git a/arch/arm/mach-mx3/mx31lite.c b/arch/arm/mach-mx3/mx31lite.c
> index def6b67..4697164 100644
> --- a/arch/arm/mach-mx3/mx31lite.c
> +++ b/arch/arm/mach-mx3/mx31lite.c
> @@ -212,11 +212,6 @@ static struct platform_device physmap_flash_device = {
>   */
>  static struct map_desc mx31lite_io_desc[] __initdata = {
>  	{
> -		.virtual = SPBA0_BASE_ADDR_VIRT,
> -		.pfn = __phys_to_pfn(SPBA0_BASE_ADDR),
> -		.length = SPBA0_SIZE,
> -		.type = MT_DEVICE_NONSHARED
> -	}, {
>  		.virtual = CS4_BASE_ADDR_VIRT,
>  		.pfn = __phys_to_pfn(CS4_BASE_ADDR),
>  		.length = CS4_SIZE,
> diff --git a/arch/arm/mach-mx3/mx31pdk.c b/arch/arm/mach-mx3/mx31pdk.c
> index 0f7a2f0..18715f1 100644
> --- a/arch/arm/mach-mx3/mx31pdk.c
> +++ b/arch/arm/mach-mx3/mx31pdk.c
> @@ -211,11 +211,6 @@ static int __init mx31pdk_init_expio(void)
>   */
>  static struct map_desc mx31pdk_io_desc[] __initdata = {
>  	{
> -		.virtual = SPBA0_BASE_ADDR_VIRT,
> -		.pfn = __phys_to_pfn(SPBA0_BASE_ADDR),
> -		.length = SPBA0_SIZE,
> -		.type = MT_DEVICE_NONSHARED,
> -	}, {
>  		.virtual = CS5_BASE_ADDR_VIRT,
>  		.pfn = __phys_to_pfn(CS5_BASE_ADDR),
>  		.length = CS5_SIZE,
> -- 
> 1.6.2.5
> 

  reply	other threads:[~2009-12-15  0:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 14:33 "ARM: MX3: fix CPU revision number detection" breaks QONG support Wolfgang Denk
2009-12-11 23:47 ` Daniel Mack
2009-12-14 13:57   ` Wolfgang Denk
2009-12-14 14:10     ` Andy Green
2009-12-14 15:04     ` Daniel Mack
2009-12-14 21:41       ` valentin.longchamp at epfl.ch
2009-12-14 22:42         ` Andy Green
2009-12-14 23:28         ` Wolfgang Denk
2009-12-14 23:27 ` [PATCH] ARM: MX3: make CPU revision number detection work on all boards Wolfgang Denk
2009-12-15  0:02   ` Daniel Mack [this message]
2009-12-15 10:37   ` Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091215000236.GI28375@buzzloop.caiaq.de \
    --to=daniel@caiaq.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.