From: Holger Schurig <holgerschurig@gmail.com>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>,
David Miller <davem@davemloft.net>,
daniel@caiaq.de, linux-kernel@vger.kernel.org, dcbw@redhat.com,
m.hirsch@raumfeld.com, netdev@vger.kernel.org,
libertas-dev@lists.infradead.org, stable@kernel.org
Subject: Re: [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs
Date: Tue, 15 Dec 2009 11:30:58 +0100 [thread overview]
Message-ID: <200912151130.59103.holgerschurig@gmail.com> (raw)
In-Reply-To: <1260871634.3692.6.camel@johannes.local>
> drivers/net/wireless/libertas$ grep lbs_deb_ * | grep ssid
> |grep '%s'
> assoc.c: lbs_deb_join("current SSID '%s', ssid length %u\n",
> assoc.c: lbs_deb_join("requested ssid '%s', ssid length %u\n",
> assoc.c: lbs_deb_join("ADHOC_START: SSID '%s', ssid
> length %u\n",
> scan.c: lbs_deb_wext("set_scan, essid '%s'\n",
All those lines are gone once my cfg80211 lands.
Do you know any way to make sparse moan about them?
BTW: the libertas firmware sometimes treat an SSID as a
zero-terminated string. There are some firmware commands that
accept just an u8[32] bytes for the SSID, but not an ssid_len,
e.g. in the CMD_802_11_AD_HOC_START command.
You therefore can't connect to the otherwise legitimate SSID of
TEST\0\0\0.
--
http://www.holgerschurig.de
WARNING: multiple messages have this Message-ID (diff)
From: Holger Schurig <holgerschurig-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Johannes Berg <johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org>,
David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
daniel-rDUAYElUppE@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dcbw-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
m.hirsch-5g8ninUHluJWk0Htik3J/w@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
libertas-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
stable-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs
Date: Tue, 15 Dec 2009 11:30:58 +0100 [thread overview]
Message-ID: <200912151130.59103.holgerschurig@gmail.com> (raw)
In-Reply-To: <1260871634.3692.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
> drivers/net/wireless/libertas$ grep lbs_deb_ * | grep ssid
> |grep '%s'
> assoc.c: lbs_deb_join("current SSID '%s', ssid length %u\n",
> assoc.c: lbs_deb_join("requested ssid '%s', ssid length %u\n",
> assoc.c: lbs_deb_join("ADHOC_START: SSID '%s', ssid
> length %u\n",
> scan.c: lbs_deb_wext("set_scan, essid '%s'\n",
All those lines are gone once my cfg80211 lands.
Do you know any way to make sparse moan about them?
BTW: the libertas firmware sometimes treat an SSID as a
zero-terminated string. There are some firmware commands that
accept just an u8[32] bytes for the SSID, but not an ssid_len,
e.g. in the CMD_802_11_AD_HOC_START command.
You therefore can't connect to the otherwise legitimate SSID of
TEST\0\0\0.
--
http://www.holgerschurig.de
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-15 10:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-12 20:47 [PATCH] wireless: wext: allocate space for NULL-termination for 32byte SSIDs Daniel Mack
2009-12-15 9:43 ` David Miller
2009-12-15 10:03 ` Johannes Berg
2009-12-15 10:05 ` Johannes Berg
2009-12-15 10:07 ` Johannes Berg
2009-12-15 10:20 ` Daniel Mack
2009-12-15 10:20 ` Daniel Mack
2009-12-15 10:31 ` Johannes Berg
2009-12-15 10:31 ` Johannes Berg
2009-12-15 10:37 ` Daniel Mack
2009-12-15 10:30 ` Holger Schurig [this message]
2009-12-15 10:30 ` Holger Schurig
2009-12-15 10:35 ` Johannes Berg
2009-12-15 10:35 ` Johannes Berg
2009-12-16 6:54 ` Albert Cahalan
2009-12-16 6:54 ` Albert Cahalan
2009-12-16 8:19 ` Johannes Berg
2009-12-16 8:26 ` Holger Schurig
2009-12-16 3:58 ` Daniel Mack
2009-12-16 8:20 ` Johannes Berg
2009-12-15 10:16 ` Albert Cahalan
2009-12-15 10:16 ` Albert Cahalan
2009-12-15 16:29 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912151130.59103.holgerschurig@gmail.com \
--to=holgerschurig@gmail.com \
--cc=daniel@caiaq.de \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=johannes@sipsolutions.net \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=m.hirsch@raumfeld.com \
--cc=netdev@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.