All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org
Subject: Re: [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion
Date: Wed, 16 Dec 2009 23:14:50 +0800	[thread overview]
Message-ID: <20091216151450.GA2804@hack> (raw)
In-Reply-To: <1260974161-6934-1-git-send-email-yong.zhang0@gmail.com>

On Wed, Dec 16, 2009 at 10:35:56PM +0800, Yong Zhang wrote:
>The _ONSTACK variant should be used for on-stack completion,
>otherwise it will break lockdep.
>
>Yong Zhang (5):
> aha152x: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> USB: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> hwmon: use DECLARE_COMPLETION_ONSTACK for non-constant completion
> powerpc/iseries: use DECLARE_COMPLETION_ONSTACK for non-constant completion

These all look fine for me.

Reviewed-by: WANG Cong <xiyou.wangcong@gmail.com>

For lockdep stuff, you should Cc Peter, adding him into Cc...

Thanks.


>
> arch/powerpc/platforms/iseries/viopath.c |    2 +-
> drivers/hwmon/ams/ams-pmu.c              |    4 ++--
> drivers/isdn/mISDN/l1oip_core.c          |    2 +-
> drivers/scsi/aha152x.c                   |    2 +-
> drivers/usb/gadget/fsl_qe_udc.c          |    2 +-
> drivers/usb/gadget/fsl_udc_core.c        |    2 +-
> drivers/usb/gadget/langwell_udc.c        |    2 +-
> 7 files changed, 8 insertions(+), 8 deletions(-)
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

-- 
Live like a child, think like the god.
 

      parent reply	other threads:[~2009-12-16 15:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-16 14:35 [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion Yong Zhang
2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang
2009-12-16 14:35   ` Yong Zhang
2009-12-16 14:35   ` [PATCH 2/5] hwmon: " Yong Zhang
2009-12-16 14:35     ` [PATCH 3/5] USB: " Yong Zhang
2009-12-16 14:36       ` [PATCH 4/5] mISDN: " Yong Zhang
2009-12-16 14:36         ` [PATCH 5/5] aha152x: " Yong Zhang
2009-12-16 19:00         ` [PATCH 4/5] mISDN: " Karsten Keil
2009-12-19  4:30           ` David Miller
2009-12-16 15:14 ` Américo Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091216151450.GA2804@hack \
    --to=xiyou.wangcong@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=yong.zhang0@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.