From: Karsten Keil <keil@b1-systems.de>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Andreas Eversberg <andreas@eversberg.eu>,
Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: Re: [PATCH 4/5] mISDN: use DECLARE_COMPLETION_ONSTACK for non-constant completion
Date: Wed, 16 Dec 2009 20:00:20 +0100 [thread overview]
Message-ID: <200912162000.20642.keil@b1-systems.de> (raw)
In-Reply-To: <1260974161-6934-5-git-send-email-yong.zhang0@gmail.com>
The _ONSTACK variant should be used for on-stack completion,
otherwise it will break lockdep.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: Karsten Keil <keil@b1-systems.de>
Cc: David S. Miller <davem@davemloft.net>
Cc: Andreas Eversberg <andreas@eversberg.eu>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
drivers/isdn/mISDN/l1oip_core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/isdn/mISDN/l1oip_core.c b/drivers/isdn/mISDN/l1oip_core.c
index 7e5f30d..f1e8af5 100644
--- a/drivers/isdn/mISDN/l1oip_core.c
+++ b/drivers/isdn/mISDN/l1oip_core.c
@@ -661,7 +661,7 @@ l1oip_socket_thread(void *data)
size_t recvbuf_size = 1500;
int recvlen;
struct socket *socket = NULL;
- DECLARE_COMPLETION(wait);
+ DECLARE_COMPLETION_ONSTACK(wait);
/* allocate buffer memory */
recvbuf = kmalloc(recvbuf_size, GFP_KERNEL);
next prev parent reply other threads:[~2009-12-16 19:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 14:35 [PATCH 0/5] use DECLARE_COMPLETION_ONSTACK for non-constant completion Yong Zhang
2009-12-16 14:35 ` [PATCH 1/5] powerpc/iseries: " Yong Zhang
2009-12-16 14:35 ` Yong Zhang
2009-12-16 14:35 ` [PATCH 2/5] hwmon: " Yong Zhang
2009-12-16 14:35 ` [PATCH 3/5] USB: " Yong Zhang
2009-12-16 14:36 ` [PATCH 4/5] mISDN: " Yong Zhang
2009-12-16 14:36 ` [PATCH 5/5] aha152x: " Yong Zhang
2009-12-16 19:00 ` Karsten Keil [this message]
2009-12-19 4:30 ` [PATCH 4/5] mISDN: " David Miller
2009-12-16 15:14 ` [PATCH 0/5] " Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912162000.20642.keil@b1-systems.de \
--to=keil@b1-systems.de \
--cc=acme@redhat.com \
--cc=andreas@eversberg.eu \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yong.zhang0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.