* [PATCH 2/3]posix acl:Add an acl check
@ 2009-12-17 14:24 Liuweni
0 siblings, 0 replies; only message in thread
From: Liuweni @ 2009-12-17 14:24 UTC (permalink / raw)
To: linux-fsdevel, linux-kernel, viro
Cc: strongzgy, Xiao Guangrong, Liu Hui, qingshenlwy
In this function, the parameter of acl will be called by FOREACH_ACL_ENTRY(macro)
without null pointer check.
I add a Null point checker to it.
In the fs/btrfs/btrfs_acl.c, the posix_acl_equiv_mode will make a error by null pointer.
---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 39df95a..37d0485 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -150,6 +150,9 @@ posix_acl_equiv_mode(const struct posix_acl *acl, mode_t *mode_p)
mode_t mode = 0;
int not_equiv = 0;
+ if(!acl)
+ return -EINVAL;
+
FOREACH_ACL_ENTRY(pa, acl, pe) {
switch (pa->e_tag) {
case ACL_USER_OBJ:
--------------
Best Regards,
Liuweni
2009-12-17
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-17 14:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-17 14:24 [PATCH 2/3]posix acl:Add an acl check Liuweni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.