From: Dave McCracken <dcm@mccr.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, xen-devel@lists.xensource.com
Subject: Re: [PATCH] linux/balloon: prefer using pages from balloon in alloc_empty_pages_and_pagevec()
Date: Fri, 18 Dec 2009 08:32:54 -0600 [thread overview]
Message-ID: <200912180832.54632.dcm@mccr.org> (raw)
In-Reply-To: <4B2B42DD020000780002694A@vpn.id2.novell.com>
On Friday 18 December 2009, Jan Beulich wrote:
> >>> Dave McCracken <dcm@mccr.org> 17.12.09 21:33 >>>
> >
> >I don't see anything wrong with the error path. It correctly walks back
> > down the pagevec and frees all the pages it's allocated so far.
>
> Oh, you're probably looking at the code past the err: label, but I was
> referring to the handling of a failed apply_to_page_range().
Ok, yeah. It frees up the page that's currently being worked on, then jumps
to err: to clean up all the other pages in the pagevec and free the pagevec.
Is there something wrong about it that I'm missing?
Dave McCracken
Oracle Corp
next prev parent reply other threads:[~2009-12-18 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 15:13 [PATCH] linux/balloon: prefer using pages from balloon in alloc_empty_pages_and_pagevec() Jan Beulich
2009-12-16 15:32 ` Jan Beulich
2009-12-17 20:33 ` Dave McCracken
2009-12-18 7:52 ` Jan Beulich
2009-12-18 14:32 ` Dave McCracken [this message]
2009-12-18 15:01 ` Jan Beulich
2009-12-18 21:03 ` Dave McCracken
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912180832.54632.dcm@mccr.org \
--to=dcm@mccr.org \
--cc=JBeulich@novell.com \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.