All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Keir Fraser <Keir.Fraser@eu.citrix.com>
Subject: Re: [PATCH 1 of 3] If Xen backend modules are not loaded, load them before starting Xend
Date: Tue, 22 Dec 2009 14:57:53 -0500	[thread overview]
Message-ID: <20091222195753.GB31761@phenom.dumpdata.com> (raw)
In-Reply-To: <1261510877.27802.19.camel@localhost.localdomain>

On Tue, Dec 22, 2009 at 07:41:17PM +0000, Ian Campbell wrote:
> On Tue, 2009-12-22 at 16:48 +0000, Konrad Rzeszutek Wilk wrote:
> > @@ -28,6 +28,7 @@
> >       grep '    xenfs$' /proc/filesystems >/dev/null && \
> >     ! grep '^xenfs ' /proc/mounts >/dev/null;
> >  then
> > +       modprobe -q xenfs
> >         mount -t xenfs xenfs /proc/xen
> >  fi
> >   
> 
> I think this one gets requested automatically if the filesystem isn't
> currently present, see the call to request_module in
> fs/filesystems.c:get_fs_type()

Hmm, in 2.6.32 it looks to be usuable only once the filesystem has
loaded. This patch is for the case where the filesystem (xenfs) is compiled
as a module - and had not been loaded. Hence hadn't had a chance to call
fs/filesystem.c:register_filesystem().

Thought maybe I messing up this up. The "grep 'xenfs$' /proc/filesystem" checks
for xenfs in /proc/filesystem so it should not even get to the "then" statement.

Something is fishy here. Why don't we skip this patch and I will revist it
after holidays.

  reply	other threads:[~2009-12-22 19:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 16:48 [PATCH 0 of 3] Patches when Linux Xen drivers are modules Konrad Rzeszutek Wilk
2009-12-22 16:48 ` [PATCH 1 of 3] If Xen backend modules are not loaded, load them before starting Xend Konrad Rzeszutek Wilk
2009-12-22 19:41   ` Ian Campbell
2009-12-22 19:57     ` Konrad Rzeszutek Wilk [this message]
2009-12-22 21:59       ` Ian Campbell
2009-12-22 16:48 ` [PATCH 2 of 3] [xen-detect] Return 0 if no Xen detected; 1 if running in PV context; and 2 if in HVM context Konrad Rzeszutek Wilk
2009-12-22 20:16   ` Keir Fraser
2009-12-22 16:48 ` [PATCH 3 of 3] [xen-detect] Add arguments to print out only outputs we are interested in Konrad Rzeszutek Wilk
2009-12-22 20:21   ` Keir Fraser
2009-12-22 20:26     ` Konrad Rzeszutek Wilk
2009-12-22 20:38       ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091222195753.GB31761@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Keir.Fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.