From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Haicheng Li <haicheng.li@linux.intel.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Matt Mackall <mpm@selenic.com>,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: initialize unused alien cache entry as NULL at alloc_alien_cache().
Date: Wed, 23 Dec 2009 11:23:43 +0100 [thread overview]
Message-ID: <20091223102343.GD20539@basil.fritz.box> (raw)
In-Reply-To: <4B31EC7C.7000302@gmail.com>
> Then, this is a violation of the first statement :
>
> nr_node_ids = 1 + nid of highest POSSIBLE node.
>
> If your system allows hotplugging of new nodes, then POSSIBLE nodes should include them
> at boot time.
Agreed, nr_node_ids must be possible nodes.
It should have been set up by the SRAT parser (modulo regressions)
Haicheng, did you verify with printk it's really incorrect at this point?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Haicheng Li <haicheng.li@linux.intel.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>,
Matt Mackall <mpm@selenic.com>,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] slab: initialize unused alien cache entry as NULL at alloc_alien_cache().
Date: Wed, 23 Dec 2009 11:23:43 +0100 [thread overview]
Message-ID: <20091223102343.GD20539@basil.fritz.box> (raw)
In-Reply-To: <4B31EC7C.7000302@gmail.com>
> Then, this is a violation of the first statement :
>
> nr_node_ids = 1 + nid of highest POSSIBLE node.
>
> If your system allows hotplugging of new nodes, then POSSIBLE nodes should include them
> at boot time.
Agreed, nr_node_ids must be possible nodes.
It should have been set up by the SRAT parser (modulo regressions)
Haicheng, did you verify with printk it's really incorrect at this point?
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-23 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 12:38 [PATCH] slab: initialize unused alien cache entry as NULL at alloc_alien_cache() Haicheng Li
2009-12-22 12:38 ` Haicheng Li
2009-12-22 12:40 ` Andi Kleen
2009-12-22 12:40 ` Andi Kleen
2009-12-22 15:47 ` Christoph Lameter
2009-12-22 15:47 ` Christoph Lameter
2009-12-23 6:52 ` Haicheng Li
2009-12-23 6:52 ` Haicheng Li
2009-12-23 10:10 ` Eric Dumazet
2009-12-23 10:10 ` Eric Dumazet
2009-12-23 10:23 ` Andi Kleen [this message]
2009-12-23 10:23 ` Andi Kleen
2009-12-23 11:23 ` Haicheng Li
2009-12-23 11:23 ` Haicheng Li
2010-01-04 17:26 ` Christoph Lameter
2010-01-04 17:26 ` Christoph Lameter
2009-12-22 22:38 ` Matt Mackall
2009-12-22 22:38 ` Matt Mackall
2009-12-23 9:58 ` [PATCH v2] " Haicheng Li
2009-12-23 9:58 ` Haicheng Li
2010-01-04 17:27 ` Christoph Lameter
2010-01-04 17:27 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091223102343.GD20539@basil.fritz.box \
--to=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=haicheng.li@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.