From: Robert Millan <rmh@aybabtu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] byte-addressable grub_pci_make_address
Date: Thu, 24 Dec 2009 22:50:11 +0100 [thread overview]
Message-ID: <20091224215011.GP12122@thorin> (raw)
In-Reply-To: <4B30D3B9.2010705@gmail.com>
On Tue, Dec 22, 2009 at 03:12:09PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> === modified file 'commands/efi/loadbios.c'
> --- commands/efi/loadbios.c 2009-12-21 22:06:04 +0000
> +++ commands/efi/loadbios.c 2009-12-22 12:03:12 +0000
> @@ -50,7 +50,7 @@
> return 0;
> }
>
> - addr = grub_pci_make_address (dev, 36);
> + addr = grub_pci_make_address (dev, 144);
> grub_pci_write_byte (addr++, 0x30);
> grub_pci_write_byte (addr++, 0x33);
> grub_pci_write_byte (addr++, 0x33);
> @@ -76,7 +76,7 @@
> grub_pci_address_t addr;
> grub_pci_device_t dev = { .bus = 0, .device = 0, .function = 0};
>
> - addr = grub_pci_make_address (dev, 36);
> + addr = grub_pci_make_address (dev, 144);
These look like black magic. Could they be macroified instead?
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi
next prev parent reply other threads:[~2009-12-24 21:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 14:12 [PATCH] byte-addressable grub_pci_make_address Vladimir 'φ-coder/phcoder' Serbinenko
2009-12-24 21:50 ` Robert Millan [this message]
2009-12-24 22:16 ` Seth Goldberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091224215011.GP12122@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.