All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: pull request: wireless-next-2.6 2009-12-24
Date: Thu, 24 Dec 2009 23:47:59 -0500	[thread overview]
Message-ID: <20091225044759.GA11186@tuxdriver.com> (raw)
In-Reply-To: <20091224.135314.193725771.davem@davemloft.net>

On Thu, Dec 24, 2009 at 01:53:14PM -0800, David Miller wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Thu, 24 Dec 2009 15:47:22 -0500
> 
> > Dave,
> > 
> > Here is the usual first batch of pent-up wireless patches after the
> > merge window.  It is the usual collection of various driver updates
> > along with a dozen or so mac80211/infrastructure changes.  There is
> > still more, but lots/most of what remains is dependent not only on this
> > batch but also on the fixes that only recently made it into net-next-2.6
> > (and which are not yet in wireless-next-2.6).  So, something to look
> > forward to... :-)
> > 
> > Please let me know if there are problems!
> 
> Let me know when it builds :-)
> 
> awk: /home/davem/src/GIT/net-next-2.6/net/wireless/genregdb.awk: line 29: regular expression compile failed (missing operand)
> * Ignore *
> awk: /home/davem/src/GIT/net-next-2.6/net/wireless/genregdb.awk: line 33: regular expression compile failed (missing operand)
> * Ignore *
> make[2]: *** [net/wireless/regdb.c] Error 2
> make[2]: *** Waiting for unfinished jobs....

Hmm...well, I'm at a loss.  It certainly works here. :-)

Perhaps you could send me your config?  And maybe the output of
"awk -W version"?  I suppose it is possible that I'm relying on some
specific awk feature that isn't commonly available...?

Actually, I think it has to do with the C-style comments on the
cited lines.  Try the patch below?  If it works for you, perhaps you
could just apply it on top of the request pull?

John

---

>From 0d5105fb0d1cb949ebb54eb50c4affd33328b866 Mon Sep 17 00:00:00 2001
From: John W. Linville <linville@tuxdriver.com>
Date: Thu, 24 Dec 2009 23:44:51 -0500
Subject: [PATCH] wireless: fix comments in genregdb.awk

Apparently some awk versions choke on C-style comments -- who knew? :-)

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 net/wireless/genregdb.awk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/wireless/genregdb.awk b/net/wireless/genregdb.awk
index 8316cf0..3cc9e69 100644
--- a/net/wireless/genregdb.awk
+++ b/net/wireless/genregdb.awk
@@ -26,11 +26,11 @@ BEGIN {
 }
 
 /^[ \t]*#/ {
-	/* Ignore */
+	# Ignore
 }
 
 !active && /^[ \t]*$/ {
-	/* Ignore */
+	# Ignore
 }
 
 !active && /country/ {
-- 
1.6.5.2

-- 
John W. Linville                Someday the world will need a hero, and you
linville@tuxdriver.com                  might be all we have.  Be ready.

WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: David Miller <davem@davemloft.net>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: pull request: wireless-next-2.6 2009-12-24
Date: Thu, 24 Dec 2009 23:47:59 -0500	[thread overview]
Message-ID: <20091225044759.GA11186@tuxdriver.com> (raw)
In-Reply-To: <20091224.135314.193725771.davem@davemloft.net>

On Thu, Dec 24, 2009 at 01:53:14PM -0800, David Miller wrote:
> From: "John W. Linville" <linville@tuxdriver.com>
> Date: Thu, 24 Dec 2009 15:47:22 -0500
> 
> > Dave,
> > 
> > Here is the usual first batch of pent-up wireless patches after the
> > merge window.  It is the usual collection of various driver updates
> > along with a dozen or so mac80211/infrastructure changes.  There is
> > still more, but lots/most of what remains is dependent not only on this
> > batch but also on the fixes that only recently made it into net-next-2.6
> > (and which are not yet in wireless-next-2.6).  So, something to look
> > forward to... :-)
> > 
> > Please let me know if there are problems!
> 
> Let me know when it builds :-)
> 
> awk: /home/davem/src/GIT/net-next-2.6/net/wireless/genregdb.awk: line 29: regular expression compile failed (missing operand)
> * Ignore *
> awk: /home/davem/src/GIT/net-next-2.6/net/wireless/genregdb.awk: line 33: regular expression compile failed (missing operand)
> * Ignore *
> make[2]: *** [net/wireless/regdb.c] Error 2
> make[2]: *** Waiting for unfinished jobs....

Hmm...well, I'm at a loss.  It certainly works here. :-)

Perhaps you could send me your config?  And maybe the output of
"awk -W version"?  I suppose it is possible that I'm relying on some
specific awk feature that isn't commonly available...?

Actually, I think it has to do with the C-style comments on the
cited lines.  Try the patch below?  If it works for you, perhaps you
could just apply it on top of the request pull?

John

---

From 0d5105fb0d1cb949ebb54eb50c4affd33328b866 Mon Sep 17 00:00:00 2001
From: John W. Linville <linville@tuxdriver.com>
Date: Thu, 24 Dec 2009 23:44:51 -0500
Subject: [PATCH] wireless: fix comments in genregdb.awk

Apparently some awk versions choke on C-style comments -- who knew? :-)

Signed-off-by: John W. Linville <linville@tuxdriver.com>
---
 net/wireless/genregdb.awk |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/wireless/genregdb.awk b/net/wireless/genregdb.awk
index 8316cf0..3cc9e69 100644
--- a/net/wireless/genregdb.awk
+++ b/net/wireless/genregdb.awk
@@ -26,11 +26,11 @@ BEGIN {
 }
 
 /^[ \t]*#/ {
-	/* Ignore */
+	# Ignore
 }
 
 !active && /^[ \t]*$/ {
-	/* Ignore */
+	# Ignore
 }
 
 !active && /country/ {
-- 
1.6.5.2

-- 
John W. Linville                Someday the world will need a hero, and you
linville@tuxdriver.com                  might be all we have.  Be ready.

  reply	other threads:[~2009-12-25  4:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-24 20:47 pull request: wireless-next-2.6 2009-12-24 John W. Linville
2009-12-24 20:47 ` John W. Linville
2009-12-24 21:53 ` David Miller
2009-12-24 21:53   ` David Miller
2009-12-25  4:47   ` John W. Linville [this message]
2009-12-25  4:47     ` John W. Linville
2009-12-25  5:51     ` Pavel Roskin
2009-12-25 16:38       ` John W. Linville
2009-12-25 16:38         ` John W. Linville
2009-12-26  1:10         ` David Miller
2009-12-26  1:10           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091225044759.GA11186@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=davem@davemloft.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.