All of lore.kernel.org
 help / color / mirror / Atom feed
From: jsun@junsun.net (Jun Sun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] error message when FLAT reloc symbol is invalid, v2
Date: Thu, 31 Dec 2009 17:28:52 -0800	[thread overview]
Message-ID: <20100101012852.GC16887@Pogoplug> (raw)

See the attachement.

Jun
-------------- next part --------------
This patch fixes a cosmetic error in printk. Text segment and data/bss
segment are allocated from two different areas. It is not meaningful to
give the diff between them in the error reporting messages.

Signed-off-by: Jun Sun <jsun@junsun.net>
---

diff -Nru linux-2.6.32.2/fs/binfmt_flat.c.orig linux-2.6.32.2/fs/binfmt_flat.c
--- linux-2.6.32.2/fs/binfmt_flat.c.orig	2009-12-18 14:27:07.000000000 -0800
+++ linux-2.6.32.2/fs/binfmt_flat.c	2009-12-26 08:22:43.000000000 -0800
@@ -355,7 +355,7 @@
 
 	if (!flat_reloc_valid(r, start_brk - start_data + text_len)) {
 		printk("BINFMT_FLAT: reloc outside program 0x%x (0 - 0x%x/0x%x)",
-		       (int) r,(int)(start_brk-start_code),(int)text_len);
+		       (int) r,(int)(start_brk-start_data+text_len),(int)text_len);
 		goto failed;
 	}
 

WARNING: multiple messages have this Message-ID (diff)
From: Jun Sun <jsun@junsun.net>
To: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org
Subject: [PATCH] error message when FLAT reloc symbol is invalid, v2
Date: Thu, 31 Dec 2009 17:28:52 -0800	[thread overview]
Message-ID: <20100101012852.GC16887@Pogoplug> (raw)

[-- Attachment #1: Type: text/plain, Size: 26 bytes --]

See the attachement.

Jun

[-- Attachment #2: 091231-flat-invalid-reloc-symbol-output.patch --]
[-- Type: text/plain, Size: 789 bytes --]

This patch fixes a cosmetic error in printk. Text segment and data/bss
segment are allocated from two different areas. It is not meaningful to
give the diff between them in the error reporting messages.

Signed-off-by: Jun Sun <jsun@junsun.net>
---

diff -Nru linux-2.6.32.2/fs/binfmt_flat.c.orig linux-2.6.32.2/fs/binfmt_flat.c
--- linux-2.6.32.2/fs/binfmt_flat.c.orig	2009-12-18 14:27:07.000000000 -0800
+++ linux-2.6.32.2/fs/binfmt_flat.c	2009-12-26 08:22:43.000000000 -0800
@@ -355,7 +355,7 @@
 
 	if (!flat_reloc_valid(r, start_brk - start_data + text_len)) {
 		printk("BINFMT_FLAT: reloc outside program 0x%x (0 - 0x%x/0x%x)",
-		       (int) r,(int)(start_brk-start_code),(int)text_len);
+		       (int) r,(int)(start_brk-start_data+text_len),(int)text_len);
 		goto failed;
 	}
 

             reply	other threads:[~2010-01-01  1:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-01  1:28 Jun Sun [this message]
2010-01-01  1:28 ` [PATCH] error message when FLAT reloc symbol is invalid, v2 Jun Sun
2010-01-01  6:24 ` [uClinux-dev] " Mike Frysinger
2010-01-01  6:24   ` Mike Frysinger
2010-01-11  3:33 ` Greg Ungerer
2010-01-11  3:33   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100101012852.GC16887@Pogoplug \
    --to=jsun@junsun.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.