From: Robert Millan <rmh@aybabtu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] macrofy (multiterm branch)
Date: Fri, 1 Jan 2010 13:11:21 +0100 [thread overview]
Message-ID: <20100101121121.GL3692@thorin> (raw)
In-Reply-To: <20091231183156.GA25874@pina.cat>
On Thu, Dec 31, 2009 at 07:31:56PM +0100, Carles Pina i Estany wrote:
>
> Hi,
>
> Find an attached patch to macrofy pos >> 8 and pos & 0xff in multiter.
> In my opinion should be macrofied, it's more clear.
Agreed.
> === modified file 'include/grub/term.h'
> --- include/grub/term.h 2009-12-25 02:37:20 +0000
> +++ include/grub/term.h 2009-12-30 18:17:55 +0000
> @@ -32,6 +32,8 @@
> #define GRUB_TERM_ESC '\e'
> #define GRUB_TERM_TAB '\t'
> #define GRUB_TERM_BACKSPACE 8
> +#define GETX(XY) (XY >> 8)
> +#define GETY(XY) (XY & 0xff)
It should have GRUB_ prefix. Otherwise it can go in.
--
Robert Millan
"Be the change you want to see in the world" -- Gandhi
prev parent reply other threads:[~2010-01-01 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-31 18:31 [PATCH] macrofy (multiterm branch) Carles Pina i Estany
2010-01-01 12:11 ` Robert Millan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100101121121.GL3692@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.