From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Eric Miao <eric.y.miao@gmail.com>,
rpurdie@rpsys.net, lenz@cs.wisc.edu,
kernel list <linux-kernel@vger.kernel.org>,
Dirk@opfer-online.de, arminlitzel@web.de,
Cyril Hrubis <metan@ucw.cz>,
thommycheck@gmail.com,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
dbaryshkov@gmail.com, omegamoon@gmail.com, utx@penguin.cz,
linux-input@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Sat, 2 Jan 2010 23:57:33 -0800 [thread overview]
Message-ID: <20100103075733.GA1358@core.coreip.homeip.net> (raw)
In-Reply-To: <20100102135608.GA5872@ucw.cz>
On Sat, Jan 02, 2010 at 02:56:09PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > We ignore the failure right now in the mainline but that causes stack
> > > > traces on resume as we trying to disable not enabled wakeup GPIOs. That
> > > > was original Pavel's complaint.
> > >
> > > Yep...
> > >
> > > I'd say that BUG() simply should not trigger if wakeup can not be
> > > enabled/disabled for particular source...?
> >
> > Pavel,
> >
> > Could you please try the patch below and let me know if it fixes the
> > problem for you?
>
> (sorry for long delay).
>
> With 33-rc1+your patch, warnings are no longer there.
>
Thank you for testing.
> I still have one on irq191, but that's gpio button driver.
>
> But please, hold the patch for few more days. I may have cleaner/nicer
> solution. It seems that zaurus is doing something very stupid in low layers.
Sorry, it is already upstream. However I do think that the change is
needed. As long as set_irq_wake() may return an error the driver should
handle such error. Especially matrix_keypad that operates with large
number of GPIOs but has only one knob for enabling wakeup.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related?
Date: Sat, 2 Jan 2010 23:57:33 -0800 [thread overview]
Message-ID: <20100103075733.GA1358@core.coreip.homeip.net> (raw)
In-Reply-To: <20100102135608.GA5872@ucw.cz>
On Sat, Jan 02, 2010 at 02:56:09PM +0100, Pavel Machek wrote:
> Hi!
>
> > > > We ignore the failure right now in the mainline but that causes stack
> > > > traces on resume as we trying to disable not enabled wakeup GPIOs. That
> > > > was original Pavel's complaint.
> > >
> > > Yep...
> > >
> > > I'd say that BUG() simply should not trigger if wakeup can not be
> > > enabled/disabled for particular source...?
> >
> > Pavel,
> >
> > Could you please try the patch below and let me know if it fixes the
> > problem for you?
>
> (sorry for long delay).
>
> With 33-rc1+your patch, warnings are no longer there.
>
Thank you for testing.
> I still have one on irq191, but that's gpio button driver.
>
> But please, hold the patch for few more days. I may have cleaner/nicer
> solution. It seems that zaurus is doing something very stupid in low layers.
Sorry, it is already upstream. However I do think that the change is
needed. As long as set_irq_wake() may return an error the driver should
handle such error. Especially matrix_keypad that operates with large
number of GPIOs but has only one knob for enabling wakeup.
--
Dmitry
next prev parent reply other threads:[~2010-01-03 7:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-30 20:07 32-rc1 aka 32-rc2: warning at manage.c:361 (set_irq_wake), matrix-keypad related? Pavel Machek
2009-09-30 20:07 ` Pavel Machek
2009-09-30 20:07 ` Pavel Machek
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 5:06 ` Dmitry Torokhov
2009-10-06 7:58 ` Pavel Machek
2009-10-06 7:58 ` Pavel Machek
2009-10-07 4:36 ` Dmitry Torokhov
2009-10-07 4:36 ` Dmitry Torokhov
2009-10-07 4:36 ` Dmitry Torokhov
2009-10-07 14:42 ` Eric Miao
2009-10-07 14:42 ` Eric Miao
2009-10-07 14:42 ` Eric Miao
2009-10-07 16:33 ` Dmitry Torokhov
2009-10-07 16:33 ` Dmitry Torokhov
2009-10-07 16:33 ` Dmitry Torokhov
2009-10-07 21:12 ` Pavel Machek
2009-10-07 21:12 ` Pavel Machek
2009-10-07 21:12 ` Pavel Machek
2009-12-03 3:17 ` Dmitry Torokhov
2009-12-03 3:17 ` Dmitry Torokhov
2010-01-02 13:56 ` Pavel Machek
2010-01-02 13:56 ` Pavel Machek
2010-01-02 15:27 ` Pavel Machek
2010-01-02 15:27 ` Pavel Machek
2010-01-02 21:06 ` Pavel Machek
2010-01-02 21:06 ` Pavel Machek
2010-01-03 7:57 ` Dmitry Torokhov [this message]
2010-01-03 7:57 ` Dmitry Torokhov
2010-01-03 8:00 ` Pavel Machek
2010-01-03 8:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100103075733.GA1358@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=Dirk@opfer-online.de \
--cc=arminlitzel@web.de \
--cc=dbaryshkov@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=lenz@cs.wisc.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=metan@ucw.cz \
--cc=omegamoon@gmail.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rpurdie@rpsys.net \
--cc=thommycheck@gmail.com \
--cc=utx@penguin.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.