From: Kazuhisa Ichikawa <ki@epsilou.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] mm/page_alloc: fix the range check for backward merging
Date: Sun, 3 Jan 2010 21:04:35 +0900 [thread overview]
Message-ID: <20100103120435.GA3576@epsilou.com> (raw)
From: Kazuhisa Ichikawa <ki@epsilou.com>
The current check for 'backward merging' within add_active_range()
does not seem correct. start_pfn must be compared against
early_node_map[i].start_pfn (and NOT against .end_pfn) to find out
whether the new region is backward-mergeable with the existing range.
Signed-off-by: Kazuhisa Ichikawa <ki@epsilou.com>
---
(This patch applies to linux-2.6.33-rc2)
--- a/mm/page_alloc.c 2009-12-25 06:09:41.000000000 +0900
+++ b/mm/page_alloc.c 2010-01-03 19:20:36.000000000 +0900
@@ -3998,7 +3998,7 @@ void __init add_active_range(unsigned in
}
/* Merge backward if suitable */
- if (start_pfn < early_node_map[i].end_pfn &&
+ if (start_pfn < early_node_map[i].start_pfn &&
end_pfn >= early_node_map[i].start_pfn) {
early_node_map[i].start_pfn = start_pfn;
return;
WARNING: multiple messages have this Message-ID (diff)
From: Kazuhisa Ichikawa <ki@epsilou.com>
To: linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] mm/page_alloc: fix the range check for backward merging
Date: Sun, 3 Jan 2010 21:04:35 +0900 [thread overview]
Message-ID: <20100103120435.GA3576@epsilou.com> (raw)
From: Kazuhisa Ichikawa <ki@epsilou.com>
The current check for 'backward merging' within add_active_range()
does not seem correct. start_pfn must be compared against
early_node_map[i].start_pfn (and NOT against .end_pfn) to find out
whether the new region is backward-mergeable with the existing range.
Signed-off-by: Kazuhisa Ichikawa <ki@epsilou.com>
---
(This patch applies to linux-2.6.33-rc2)
--- a/mm/page_alloc.c 2009-12-25 06:09:41.000000000 +0900
+++ b/mm/page_alloc.c 2010-01-03 19:20:36.000000000 +0900
@@ -3998,7 +3998,7 @@ void __init add_active_range(unsigned in
}
/* Merge backward if suitable */
- if (start_pfn < early_node_map[i].end_pfn &&
+ if (start_pfn < early_node_map[i].start_pfn &&
end_pfn >= early_node_map[i].start_pfn) {
early_node_map[i].start_pfn = start_pfn;
return;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2010-01-03 12:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-03 12:04 Kazuhisa Ichikawa [this message]
2010-01-03 12:04 ` [PATCH] mm/page_alloc: fix the range check for backward merging Kazuhisa Ichikawa
2010-01-04 21:02 ` David Rientjes
2010-01-04 21:02 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100103120435.GA3576@epsilou.com \
--to=ki@epsilou.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.