All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] grub-probe support for NetBSD
Date: Sun, 3 Jan 2010 17:27:34 +0100	[thread overview]
Message-ID: <20100103162734.GD27698@thorin> (raw)
In-Reply-To: <4B3F2F90.2020308@labri.fr>

On Sat, Jan 02, 2010 at 12:35:44PM +0100, Grégoire Sutre wrote:
>> Can you avoid code duplication here?  Something like:
>>
>> #ifdef __NetBSD__
>>   const char *template = "%s/r%s";
>> #else
>>   const char *template = "%s/%s";
>> #endif
>
> Indeed, it's better.  But we also need a variable for the extra length  
> (3 for NetBSD and 2 otherwise).  I have updated the patch.

I understand;  don't worry about that, GCC is smart and space is cheap in
util/ anyway.

> http://pkgsrc-wip.cvs.sourceforge.net/viewvc/*checkout*/pkgsrc-wip/wip/grub2-current/patches/patch-grub-probe-netbsd

Would you please send patches as attachments?  URLs don't make it easy for
review.

Thanks!

-- 
Robert Millan

  "Be the change you want to see in the world" -- Gandhi



  parent reply	other threads:[~2010-01-03 16:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-27 19:08 [PATCH] grub-probe support for NetBSD Grégoire Sutre
2009-12-29  1:31 ` Grégoire Sutre
2010-01-01 11:39   ` Robert Millan
2010-01-02 11:35     ` Grégoire Sutre
2010-01-02 11:40       ` Vladimir 'φ-coder/phcoder' Serbinenko
2010-01-02 11:46         ` Grégoire Sutre
2010-01-03 16:27       ` Robert Millan [this message]
2010-01-04  1:32 ` Grégoire Sutre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100103162734.GD27698@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.