All of lore.kernel.org
 help / color / mirror / Atom feed
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org,
	Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Pavel Emelyanov <xemul@openvz.org>,
	Dan Malek <dan@embeddedalley.com>,
	Vladislav Buzov <vbuzov@embeddedalley.com>,
	Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
	Alexander Shishkin <virtuoso@slind.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] cgroup notifications API and memory thresholds
Date: Mon, 4 Jan 2010 06:06:12 +0530	[thread overview]
Message-ID: <20100104003612.GF16187@balbir.in.ibm.com> (raw)
In-Reply-To: <cover.1262186097.git.kirill@shutemov.name>

* Kirill A. Shutemov <kirill@shutemov.name> [2009-12-30 17:57:55]:

> This patchset introduces eventfd-based API for notifications in cgroups and
> implements memory notifications on top of it.
> 
> It uses statistics in memory controler to track memory usage.
> 
> Output of time(1) on building kernel on tmpfs:
> 
> Root cgroup before changes:
> 	make -j2  506.37 user 60.93s system 193% cpu 4:52.77 total
> Non-root cgroup before changes:
> 	make -j2  507.14 user 62.66s system 193% cpu 4:54.74 total
> Root cgroup after changes (0 thresholds):
> 	make -j2  507.13 user 62.20s system 193% cpu 4:53.55 total
> Non-root cgroup after changes (0 thresholds):
> 	make -j2  507.70 user 64.20s system 193% cpu 4:55.70 total
> Root cgroup after changes (1 thresholds, never crossed):
> 	make -j2  506.97 user 62.20s system 193% cpu 4:53.90 total
> Non-root cgroup after changes (1 thresholds, never crossed):
> 	make -j2  507.55 user 64.08s system 193% cpu 4:55.63 total
> 
> Any comments?

Hi,

I just saw that the notification work for me using the tool you
supplied. One strange thing was that I got notified even though
the amount of data I was using was reducing, so I hit the notification
two ways

        +------------+-----------
                    1G
                ----> (got notified on increase)
                <---- (got notified on decrease)

I am not against the behaviour, but it can be confusing unless
clarified with the event.

-- 
	Balbir

WARNING: multiple messages have this Message-ID (diff)
From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org,
	Paul Menage <menage@google.com>, Li Zefan <lizf@cn.fujitsu.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	Pavel Emelyanov <xemul@openvz.org>,
	Dan Malek <dan@embeddedalley.com>,
	Vladislav Buzov <vbuzov@embeddedalley.com>,
	Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>,
	Alexander Shishkin <virtuoso@slind.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/4] cgroup notifications API and memory thresholds
Date: Mon, 4 Jan 2010 06:06:12 +0530	[thread overview]
Message-ID: <20100104003612.GF16187@balbir.in.ibm.com> (raw)
In-Reply-To: <cover.1262186097.git.kirill@shutemov.name>

* Kirill A. Shutemov <kirill@shutemov.name> [2009-12-30 17:57:55]:

> This patchset introduces eventfd-based API for notifications in cgroups and
> implements memory notifications on top of it.
> 
> It uses statistics in memory controler to track memory usage.
> 
> Output of time(1) on building kernel on tmpfs:
> 
> Root cgroup before changes:
> 	make -j2  506.37 user 60.93s system 193% cpu 4:52.77 total
> Non-root cgroup before changes:
> 	make -j2  507.14 user 62.66s system 193% cpu 4:54.74 total
> Root cgroup after changes (0 thresholds):
> 	make -j2  507.13 user 62.20s system 193% cpu 4:53.55 total
> Non-root cgroup after changes (0 thresholds):
> 	make -j2  507.70 user 64.20s system 193% cpu 4:55.70 total
> Root cgroup after changes (1 thresholds, never crossed):
> 	make -j2  506.97 user 62.20s system 193% cpu 4:53.90 total
> Non-root cgroup after changes (1 thresholds, never crossed):
> 	make -j2  507.55 user 64.08s system 193% cpu 4:55.63 total
> 
> Any comments?

Hi,

I just saw that the notification work for me using the tool you
supplied. One strange thing was that I got notified even though
the amount of data I was using was reducing, so I hit the notification
two ways

        +------------+-----------
                    1G
                ----> (got notified on increase)
                <---- (got notified on decrease)

I am not against the behaviour, but it can be confusing unless
clarified with the event.

-- 
	Balbir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  parent reply	other threads:[~2010-01-04  0:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-30 15:57 [PATCH v5 0/4] cgroup notifications API and memory thresholds Kirill A. Shutemov
2009-12-30 15:57 ` Kirill A. Shutemov
2009-12-30 15:57 ` [PATCH v5 1/4] cgroup: implement eventfd-based generic API for notifications Kirill A. Shutemov
2009-12-30 15:57   ` Kirill A. Shutemov
2010-01-07  1:01   ` Paul Menage
2010-01-07  1:01     ` Paul Menage
2010-01-07 12:36     ` Kirill A. Shutemov
2010-01-07 12:36       ` Kirill A. Shutemov
2010-01-08  0:55       ` Li Zefan
2010-01-08  0:55         ` Li Zefan
2010-01-08  1:05         ` Paul Menage
2010-01-08  1:05           ` Paul Menage
     [not found]         ` <4B46828C.5000703-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2010-01-08  1:05           ` Paul Menage
     [not found]       ` <cc557aab1001070436w446ef85n55dd2af5e733f55e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-08  0:55         ` Li Zefan
     [not found]     ` <6599ad831001061701x72098dacn7a5d916418396e33-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-01-07 12:36       ` Kirill A. Shutemov
     [not found]   ` <9411cbdd545e1232c916bfef03a60cf95510016d.1262186098.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2010-01-07  1:01     ` Paul Menage
2009-12-30 15:57 ` [PATCH v5 2/4] memcg: extract mem_group_usage() from mem_cgroup_read() Kirill A. Shutemov
2009-12-30 15:57   ` Kirill A. Shutemov
2009-12-30 15:57 ` [PATCH v5 3/4] memcg: rework usage of stats by soft limit Kirill A. Shutemov
2009-12-30 15:57   ` Kirill A. Shutemov
2010-01-03 23:56   ` KAMEZAWA Hiroyuki
2010-01-03 23:56     ` KAMEZAWA Hiroyuki
     [not found]   ` <03152dd4f660cff87b16bb581718b1c53d4775aa.1262186098.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2010-01-03 23:56     ` KAMEZAWA Hiroyuki
2009-12-30 15:57 ` [PATCH v5 4/4] memcg: implement memory thresholds Kirill A. Shutemov
2009-12-30 15:57   ` Kirill A. Shutemov
2010-01-04  0:00   ` KAMEZAWA Hiroyuki
2010-01-04  0:00     ` KAMEZAWA Hiroyuki
     [not found]   ` <0e92010cf06de5cd860df92f22fddbd23ece8a87.1262186099.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2010-01-04  0:00     ` KAMEZAWA Hiroyuki
2010-01-04  0:36 ` Balbir Singh [this message]
2010-01-04  0:36   ` [PATCH v5 0/4] cgroup notifications API and " Balbir Singh
2010-01-04 10:15   ` Kirill A. Shutemov
2010-01-04 10:15     ` Kirill A. Shutemov
     [not found]   ` <20100104003612.GF16187-SINUvgVNF2CyUtPGxGje5AC/G2K4zDHf@public.gmane.org>
2010-01-04 10:15     ` Kirill A. Shutemov
     [not found] ` <cover.1262186097.git.kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org>
2009-12-30 15:57   ` [PATCH v5 1/4] cgroup: implement eventfd-based generic API for notifications Kirill A. Shutemov
2009-12-30 15:57   ` [PATCH v5 2/4] memcg: extract mem_group_usage() from mem_cgroup_read() Kirill A. Shutemov
2009-12-30 15:57   ` [PATCH v5 3/4] memcg: rework usage of stats by soft limit Kirill A. Shutemov
2009-12-30 15:57   ` [PATCH v5 4/4] memcg: implement memory thresholds Kirill A. Shutemov
2010-01-04  0:36   ` [PATCH v5 0/4] cgroup notifications API and " Balbir Singh
  -- strict thread matches above, loose matches on Subject: below --
2009-12-30 15:57 Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100104003612.GF16187@balbir.in.ibm.com \
    --to=balbir@linux.vnet.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=dan@embeddedalley.com \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=nishimura@mxp.nes.nec.co.jp \
    --cc=vbuzov@embeddedalley.com \
    --cc=virtuoso@slind.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.