From: Denis Kenzior <denkenz@gmail.com>
To: ofono@ofono.org
Subject: Re: [PATCH] Fix set default baud rate to 115200
Date: Tue, 05 Jan 2010 10:32:25 -0600 [thread overview]
Message-ID: <201001051032.26241.denkenz@gmail.com> (raw)
In-Reply-To: <8B81FACE836F9248894A7844CC0BA814176735A7E6@shzsmsx501.ccr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
Hi Zhenhua,
> Hi,
>
> I found N900 could not be powered on by atgen driver due to baud rate
> problem. If I add 'Baud=115200' into modem.conf, everything is fine. In
> gatchat/gattty.c, the default baud rate is B0 which looks not correct, so
gattty code sets the serial port into raw mode if no options are given. These
days it is hard to find a real serial port device that actually needs the
options setup properly. Most simply work in raw mode.
> I wonder whether we should set the default baud rate to some values like
> minicom does.
>
> My proposed fix was attached.
The fix should really be inside atgen.c, as it logically belongs there. You
can make atgen use 'sane' defaults for true serial devices, but then you need
to add capability to put the modem into 'raw' mode.
Regards,
-Denis
prev parent reply other threads:[~2010-01-05 16:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 8:39 [PATCH] Fix set default baud rate to 115200 Zhang, Zhenhua
2010-01-05 16:32 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001051032.26241.denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=ofono@ofono.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.