[PATCH] Fix set default baud rate to 115200

[PATCH] Fix set default baud rate to 115200

[Zhang, Zhenhua]

[-- Attachment #1: Type: text/plain, Size: 371 bytes --]

Hi,

I found N900 could not be powered on by atgen driver due to baud rate problem.
If I add 'Baud=115200' into modem.conf, everything is fine. In gatchat/gattty.c,
the default baud rate is B0 which looks not correct, so I wonder whether we
should set the default baud rate to some values like minicom does.

My proposed fix was attached.

Regards,
Zhenhua
 

[-- Attachment #2: 0001-Fix-set-default-baud-rate-to-115200.patch --]
[-- Type: application/octet-stream, Size: 650 bytes --]

From b2b2b26a85f9165df582dcc8c332fc0191a29d80 Mon Sep 17 00:00:00 2001
From: Zhenhua Zhang <zhenhua.zhang@intel.com>
Date: Tue, 5 Jan 2010 16:23:08 +0800
Subject: [PATCH] Fix set default baud rate to 115200

---
 gatchat/gattty.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/gatchat/gattty.c b/gatchat/gattty.c
index 02ca389..94ec37f 100644
--- a/gatchat/gattty.c
+++ b/gatchat/gattty.c
@@ -198,6 +198,8 @@ static int open_device(const char *tty, GHashTable *options)
 	memset(&ti, 0, sizeof(ti));
 	cfmakeraw(&ti);
 
+	set_baud("115200", &ti);
+
 	if (options) {
 		GHashTableIter iter;
 		const char *key;
-- 
1.6.3.3

Re: [PATCH] Fix set default baud rate to 115200

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]

Hi Zhenhua,

> Hi,
> 
> I found N900 could not be powered on by atgen driver due to baud rate
>  problem. If I add 'Baud=115200' into modem.conf, everything is fine. In
>  gatchat/gattty.c, the default baud rate is B0 which looks not correct, so

gattty code sets the serial port into raw mode if no options are given.  These 
days it is hard to find a real serial port device that actually needs the 
options setup properly.  Most simply work in raw mode.

>  I wonder whether we should set the default baud rate to some values like
>  minicom does.
> 
> My proposed fix was attached.

The fix should really be inside atgen.c, as it logically belongs there.  You 
can make atgen use 'sane' defaults for true serial devices, but then you need 
to add capability to put the modem into 'raw' mode.

Regards,
-Denis